Repository navigation
fix(integrations): address the final release audit findings #10035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+272
−68
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
c71760c
fix(integrations): address the final release audit findings across No…
waleedlatif1 57b5563
fix(notion): make the rate-limit wait abortable and retry a rate-limi…
waleedlatif1 937afa3
fix(integrations): stop the stored Send status from filtering DocuSig…
waleedlatif1 fabea88
fix(workday): send Get Organizations criteria in schema order and sho…
waleedlatif1 7d3106c
fix(dropbox): keep requiring path for an initial folder listing
waleedlatif1 3be2ccc
test(workday): assert Get_Organizations element order in the XML sent…
waleedlatif1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| import { describe, expect, it } from 'vitest' | ||
| import { DocuSignBlock } from '@/blocks/blocks/docusign' | ||
|
|
||
| function runCanvas(params: Record<string, unknown>) { | ||
| const mapper = DocuSignBlock.tools.config?.params | ||
| if (!mapper) throw new Error('DocuSign block has no params mapper') | ||
| return { ...params, ...mapper(params) } | ||
| } | ||
|
|
||
| describe('DocuSign List Envelopes status filter', () => { | ||
| it('does not filter by the stored Send Envelope status when the list filter is All', () => { | ||
| const merged = runCanvas({ | ||
| operation: 'list_envelopes', | ||
| envelopeStatus: 'sent', | ||
| listEnvelopeStatus: '', | ||
| }) | ||
|
|
||
| expect(merged.envelopeStatus).toBeUndefined() | ||
| }) | ||
|
|
||
| it('sends the chosen list filter', () => { | ||
| const merged = runCanvas({ | ||
| operation: 'list_envelopes', | ||
| envelopeStatus: 'sent', | ||
| listEnvelopeStatus: 'completed', | ||
| }) | ||
|
|
||
| expect(merged.envelopeStatus).toBe('completed') | ||
| }) | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| import { describe, expect, it } from 'vitest' | ||
| import { SapConcurBlock } from '@/blocks/blocks/sap_concur' | ||
|
|
||
| const operation = 'sap_concur_list_travel_requests' | ||
|
|
||
| function mapParams(params: Record<string, unknown>, context?: { operation: string }) { | ||
| const mapper = SapConcurBlock.tools.config?.params | ||
| if (!mapper) throw new Error('SAP Concur block has no params mapper') | ||
| return mapper({ operation, ...params }, context) | ||
| } | ||
|
|
||
| describe('SAP Concur list travel requests mapping', () => { | ||
| it('keeps the model user and sort arguments on a tool call', () => { | ||
| const mapped = mapParams( | ||
| { userId: 'user-1', sortField: 'startDate', sortOrder: 'DESC' }, | ||
| { operation } | ||
| ) | ||
|
|
||
| expect(mapped.userId).toBe('user-1') | ||
| expect(mapped.sortField).toBe('startDate') | ||
| expect(mapped.sortOrder).toBe('DESC') | ||
| }) | ||
|
|
||
| it('prefers the configured subBlock over the model argument', () => { | ||
| const mapped = mapParams({ travelRequestUserId: 'configured', userId: 'model' }, { operation }) | ||
|
|
||
| expect(mapped.userId).toBe('configured') | ||
| }) | ||
|
|
||
| it('does not forward a stale same-named value on the canvas', () => { | ||
| const mapped = mapParams({ userId: 'stale-from-another-operation' }) | ||
|
|
||
| expect(mapped.userId).toBeUndefined() | ||
| }) | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.