Skip to content

fix(integrations): address the final release audit findings - #10035

Merged
waleedlatif1 merged 6 commits into
stagingfrom
fix/integration-final-audit
Nov 14, 2026
Merged

waleedlatif1 merged 6 commits into
stagingfrom
fix/integration-final-audit

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

Follow-up to #10027–#10031 from an independent per-integration release audit: 12 read-only auditors re-checked the staging-vs-main diff against vendor docs and saved-workflow behavior. None of the findings were blockers; this fixes the real ones.

  • Notion:
    • The new truncated output was missing from the generated docs (the constant lived outside types.ts) and from the V2 block outputs. It now appears in both.
    • A rate-limited (429) continuation page during Read Page is retried up to twice after Retry-After before failing.
  • Zendesk:
    • Search also strips a negated -type: filter, which the export endpoint rejects too.
    • The merge comment description says it is posted as a public reply.
  • Dropbox: List Folder treats a missing path as the root. path became optional on the tool, so an agent omitting it got an error instead of the root listing.
  • DocuSign: count/startPosition accept numbers, so chaining <docusign.endPosition> works.
  • Airtable: a non-numeric pageSize is omitted instead of being sent as NaN.
  • ClickUp: Get Time Entries falls back to the model's task/list/folder/space id when the location type is set but the id is blank.
  • Workday: the Update Worker fields example used two fields Workday rejects (businessTitle/primaryWorkEmail); it now shows a real Change_Personal_Information_Data element.
  • Pipedrive: the pipeline picker moves off the out-of-support GET /v1/pipelines to GET /api/v2/pipelines with cursor paging, matching the tool.
  • Intercom: the contact recipient option is labeled legacy, since the spec only allows user/lead. The value is unchanged for saved workflows.
  • Mailchimp: fixed a dead docs link (404) in the member-removal note.
  • SAP Concur: added a regression test for the agent tool-call argument fix. It fails on main's mapper.

Type of Change

  • Bug fix

Testing

  • New tests:
    • Notion 429 retry
    • Zendesk -type:
    • Pipedrive v2 selector paging
    • SAP Concur mapper (fails on main)
  • Affected suites (516 tests), blocks tests, check-block-registry, check:tool-metadata, check:docs, check:docs-manifest, check:integration-catalog, check:explicit-any, check:test-patterns, biome

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

…tion, Zendesk, Dropbox, DocuSign, Airtable, ClickUp, Workday, Pipedrive, Intercom, Mailchimp, and SAP Concur
@vercel

vercel Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 14, 2026 3:17am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 21 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/sim/tools/dropbox/list_folder.ts Resolved
Comment thread apps/sim/tools/workday/update_worker.ts Resolved
Comment thread apps/sim/tools/notion/read.ts Resolved
@greptile-apps

greptile-apps Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no blocking issues remain.

Summary

Fixes integration inputs, paging, retry waits, output fields, and docs.

  • Notion page reads retry continuation requests after rate limits.
  • Monday.com mutations send JSON values in the form GraphQL expects.
  • The Pipedrive pipeline picker loads results with cursor paging.
  • Notion page reads show when content stops at the block limit.
  • DocuSign paging inputs accept numbers from earlier workflow steps.
  • DocuSign's List Envelopes operation uses its selected status filter.
  • ClickUp time-entry filters fall back to IDs supplied by the model.
  • Zendesk search removes negated type filters before export.
  • Airtable list requests leave out invalid page sizes.
  • Workday organization requests put their response filter after request criteria.
  • Zendesk merge-ticket guidance says target comments are public replies.
  • Intercom labels the Contact recipient option as legacy.
  • Dropbox's missing-path message explains how to list the root folder.
  • Integration guidance shows a valid Workday update example and fixes a docs link.

Reviews (4) · Last reviewed commit: "test(workday): assert Get_Organizations ..." · Reviewed by Greptile

Comment thread apps/sim/tools/workday/update_worker.ts Resolved
Comment thread apps/sim/tools/notion/read.ts Resolved
…n List Envelopes and serialize object values for monday JSON arguments
…w the update payload shape the client marshals
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 14, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 14, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 32 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/sim/blocks/blocks/docusign.ts Resolved
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 14, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 32 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 69bfb1b into staging Nov 14, 2026
83 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/integration-final-audit branch November 14, 2026 03:24

This branch was previously deployed

1 inactive deployment
Preview — 3be2ccc7 Deployed Nov 14, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant