Repository navigation
fix(integrations): resolve agent tool-call operations and align remaining requests with vendor specs - #10036
Conversation
…n the ClickUp, Airtable, Asana, monday, SAP S/4HANA, and Workday mappers
…, and ServiceNow requests and outputs with their API specs
…tercom fields, send documented Intercom, Square, Amplitude, and Box request values, and correct SAP output types
…, throw on invalid Attio entry values, and guard the ServiceNow CI class path
…y for the monday column value
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
[High impact] The changes appear safe to merge; no new blocking issue was found. SummaryFixes agent tool arguments and brings integration requests and outputs in line with vendor specs.
Reviews (3) · Last reviewed commit: "fix(integrations): reset the shared Pipe..." · Reviewed by Greptile |
There was a problem hiding this comment.
3 issues found across 80 files
Confidence score: 3/5
- In
apps/sim/blocks/blocks/intercom.ts, dynamic-option validation can rejectrole: ''when saving a new Update Contact, so the default No change selection may not save. Pass the current operation into validation soupdate_contactaccepts it. - In
apps/sim/tools/mailchimp/create_landing_page.ts, the description omits theclick-throughcreate type, so agents may not discover an option the block still exposes. Include it in the description. - In
apps/sim/tools/supabase/types.ts, the descriptions say move responses contain only a message, but the endpoint returnsIdandKey. Update the descriptions to explain those destination values.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/sim/tools/mailchimp/create_landing_page.ts">
<violation number="1" location="apps/sim/tools/mailchimp/create_landing_page.ts:42">
P2: This description omits the retained `click-through` create type, so agents cannot discover a value that the Mailchimp block still exposes for this operation. Include the legacy option in the description or explicitly document that it is accepted for saved-workflow compatibility.</violation>
</file>
<file name="apps/sim/blocks/blocks/intercom.ts">
<violation number="1" location="apps/sim/blocks/blocks/intercom.ts:192">
P2: Saving a new Update Contact can reject its default `No change` role as an invalid dropdown value. Pass the current operation into dynamic-option validation so `role: ''` is accepted for `update_contact`.</violation>
</file>
<file name="apps/sim/tools/supabase/types.ts">
<violation number="1" location="apps/sim/tools/supabase/types.ts:91">
P3: These descriptions incorrectly tell consumers that Supabase move responses contain only a message. The endpoint returns `Id` and `Key`; restore descriptions that explain those returned destination values.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
…context, document the legacy Mailchimp landing page type, and type the ServiceNow path tests
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 80 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
…e dropdowns when the operation changes
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Summary
Fixes older bugs (already on main) that turned up during the final full pass, which checked every tool of the 24 integrations against vendor specs: OpenAPI/WSDL/XSD/GraphQL schemas and official SDKs. Every change was then audited again for saved-workflow compatibility. The three changes that could have altered what working saved workflows send were reverted to main's behavior.
Agent tool calls (ClickUp, Airtable, Asana, monday, SAP S/4HANA, Workday)
params.operation. An agent tool stores its operation outsideparamsand passes it only ascontext.operation, so those branches never ran on agent calls. As a result, values like a ClickUp workspace picked in the tool row never reached the tool.params.operation ?? context?.operation. Every renamed key has atoolCallArgfallback, so a model argument is never dropped.params.operation. A 6k-case old-vs-new fuzz of the canvas path differs only for blank required monday fields, which are rejected the same way either way.Requests and outputs aligned with vendor specs
get_campaign_reportreadscampaign_idfromid; the response has nocampaign_id.set_campaign_contentsendstemplate.idas the integer the spec requires.producttype.[]/{}. Before, this cleared task assignees, linked records and webhook subscriptions, and it turned a filtered entry query into "return everything".add_list_membershipsreadsrecordsIdsAdded; the spec spells it that way. Owner name and email outputs are optional, per the spec.idsare encoded into the query string.safeUrlPathSegment. Valid values are byte-identical.skip_notifications(2.14). Update Contact's role offers "No change".image_filemultipart part (spec plus official SDKs).ndayfor the savedn-dayvalue, and addsnday_or_before. Funnels, bracket and computations descriptions are corrected.sortthat Box rejects there. Update File sendsdescriptiononly when it is a string.SourceDetermination,IsNaturalPerson,ManualPrintIsTriggered), along with a filter example that named a nonexistent field. A modeltop/skipof 0 is kept.Type of Change
Testing
blockstests.check-block-registry,check:tool-metadata,check:docs,check:docs-manifest,check:integration-catalog,check:explicit-any,check:test-patterns, biome.buildBlockToolParamsTransformpipeline for all 127 operations.Checklist
test-auditauthoring gate)