Skip to content

ci(desktop): run the live suite's lease-lapse test on its own runner - #8980

Merged
waleedlatif1 merged 1 commit into
stagingfrom
ci/desktop-e2e-speed
Oct 13, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
ci/desktop-e2e-speed

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • desktop-live was the last check to finish in 46 of 57 recent clean PR runs and 14 of 14 staging pushes. It ran one 12-test spec serially in about 9.3 min (p90 10.7)
  • 60% of that is two deliberately long tests that outlast the real 60 s execution lease and tool budget. The lease-lapse test alone takes about 3.1 min
  • Split the job into a 2-way matrix: desktop-live (lease-lapse) runs that test via --grep @lease-lapse, and desktop-live (rest) runs the other 11 via --grep-invert. Each shard boots its own app, database and Electron, so the shards don't share state. Expected job time is about 6–7 min, below the mobile e2e chain (about 8.3 min)
  • Expected savings: about 1.4 min median off checks / ci on PRs (all a desktop-live fix can save, since the mobile chain is then the critical path) and about 2.5–3 min off staging push → deploy
  • Coverage is unchanged: every test still runs against the real lease and budget constants, with no test-only seams. A grep that matched nothing would fail the shard with "No tests found", so a renamed title can't silently drop the test
  • The gate is unchanged: needs.desktop-live.result aggregates the matrix

Type of Change

  • Improvement

Testing

  • Timing from the last 120 ci.yml runs (job and step timings, finishing order); this PR's own CI run exercises both shards
  • actionlint, biome

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Oct 13, 2026 7:30pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Heads up: you’ve reached your flex budget. Increase your flex budget or wait for usage to reset.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable issues were found.

Summary

Splits desktop-live into two runners: one runs the lease-lapse test, and the other runs the remaining 11 tests.

  • The desktop live suite runs its lease-lapse test on a separate runner.

Reviews (1) · Last reviewed commit: "ci(desktop): run the live suite's lease-..." · Reviewed by Greptile

@waleedlatif1
waleedlatif1 merged commit 496fd61 into staging Oct 13, 2026
43 checks passed
@waleedlatif1
waleedlatif1 deleted the ci/desktop-e2e-speed branch October 13, 2026 19:31

This branch was successfully deployed

1 active deployment
Preview — 05516012 Deployed Oct 13, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant