[FEM] Introduce higher accuracy quadrature rules - #6225
Conversation
ec846d2 to
5ad33f1
Compare
alxbilger
left a comment
There was a problem hiding this comment.
I would be curious to know how you use quadratureRule
|
@alxbilger |
|
[ci-depends-on] detected during build #4. To unlock the merge button, you must
|
b8c7deb to
9c42dbf
Compare
|
[ci-depends-on] detected during build #5. To unlock the merge button, you must
|
alxbilger
left a comment
There was a problem hiding this comment.
Could you just add the new quadrature points to the unit tests testSumWeights ? It's not enough, but there are not other tests for now...
|
[ci-depends-on] detected during build #6. To unlock the merge button, you must
|
|
I think you can remove the |
9bdcbf1 to
9de02d8
Compare
|
Now that we added quadratic elements, I refactored the quadrature rules. Linear or quadratic, the integration is done over the same reference domain. The rules are now re-used, implemented in The literals were also substituted by std:: variants, wherever possible. This has triggered a unit test failure in New rules can be added in the existing tables. There are two paths:
Each element has a default and minimum degree, so quadratic elements cannot use 1st order rules. |
For each Element, an option is added to use a higher-accuracy quadrature rule. The default behaviour of existing force fields is preserved. Lower-order rules are also included for completeness.
The purpose of this change is to enable more accurate error-norm computations in the V&V suite using the Method of Manufactured Solutions.
If the accuracy is insufficient, the integration introduces errors in the computed norms. This we observe either as the convergence rate approaching the expected one more slowly or as apparent superconvergence that counters the purpose of the test.
The degrees are:
[with-all-tests]
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if