Repository navigation
fix(web): delegated dispatch restores currentTarget and target (no try) - #4325
Conversation
A throwing handler is an error path that is already reported, and the try costs 13 B in every client scenario. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018LY7F9czoRqdMEvk2QwPr1
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018LY7F9czoRqdMEvk2QwPr1
🦋 Changeset detectedLatest commit: 48089a0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 15 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size (brotli, eager entry chunk)
|
|
The Generated by Claude Code |
Coverage Report for CI Build 40544687485Coverage remained the same at 78.727%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Merging this PR will improve performance by 5.93%2 warnings
Performance Changes
Tip Curious why performance improved? Comment Comparing Footnotes
|
Re-records the four scenarios the store fold stamp (#4310) and the delegated currentTarget/target restore (#4325) push past their minified allowance, measured over next with #4319. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018LY7F9czoRqdMEvk2QwPr1
|
The CodSpeed −5.5% is on Generated by Claude Code |
Supersedes #4311 and keeps brenelz's commit. The only change is that the restore no longer uses
try/finally.Before: Solid delegates events at the render root, so a native listener on
document,windowor an element above the root read the last node Solid walked ascurrentTarget.After: Once its walk ends, delegated dispatch deletes its
currentTargetandtargetoverrides. Listeners that run later in the same dispatch see the native getters.How: this is #4311 with the
try/finallydropped. A throwing handler is an error path that already gets reported, and thetrycost 13 B minified in every client scenario. The fix is now +23 B minified, down from +36 B. The test for a throwing handler is removed, and the other new tests stay, including the twotest.failscases that record the existing re-dispatch bug.Size:
app: hydrating + every store primitive familyandpage: live server componentsfail the gate here because next has no minified allowance left on those scenarios. Ryan approved raising those caps. A separate PR raises them for this fix and #4310 together, and this PR re-runs the gate once that lands. Hello world (app: compiled floor) stays under 10 KB.Tests:
uncommitted-input-overwritten, which also fails on next in this container.Generated by Claude Code