Repository navigation
Conversation
This was referenced Oct 19, 2026
erichare
changed the base branch from
fix/mcp-protocol-foundation
to
fix/mcp-update-wire-schema
October 22, 2026 18:19
3 of 4 tasks
Contributor
📈 Unit Test Coverage Delta vs Main Branch
|
Contributor
Unit Test Coverage Report
|
Contributor
📈 Integration Test Coverage Delta vs Main Branch (dse69-it)
|
Contributor
Integration Test Coverage Report (dse69-it)
|
Contributor
📉 Integration Test Coverage Delta vs Main Branch (hcd-it)
|
Contributor
Integration Test Coverage Report (hcd-it)
|
erichare
force-pushed
the
fix/mcp-request-context-cleanup
branch
from
October 24, 2026 00:36
f8b0f28 to
cca3d08
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Closes each MCP command context when a tool call succeeds, fails, or is canceled, including synchronous processor failures. Keyspace tools reuse one request context, and cleanup failures preserve the original result or error.
This builds on #2651.
Which issue(s) this PR fixes:
Part of #2629. The remaining trace-context audit keeps that issue open.
Verification
McpResourceTest: 9 tests run, 0 failures, 0 errors, 0 skipped;BUILD SUCCESS. The same invocation checked formatting for 1,196 files with 0 non-complying.JAVA_HOME=/Library/Java/JavaVirtualMachines/graalvm-21.jdk/Contents/Home ./mvnw -B -ntp test -Dtest=McpResourceTest -DskipITs -Dxml-format.skip=trueIntegration tests and manual client checks were not run in this cleanup.
Checklist