Repository navigation
Conversation
2 of 4 tasks
…ults # Conflicts: # src/main/java/io/stargate/sgv2/jsonapi/api/v1/mcp/McpResource.java
erichare
changed the base branch from
fix/mcp-protocol-foundation
to
fix/mcp-request-context-cleanup
October 22, 2026 18:19
Contributor
📈 Unit Test Coverage Delta vs Main Branch
|
Contributor
Unit Test Coverage Report
|
Contributor
📈 Integration Test Coverage Delta vs Main Branch (dse69-it)
|
Contributor
Integration Test Coverage Report (dse69-it)
|
Contributor
📈 Integration Test Coverage Delta vs Main Branch (hcd-it)
|
Contributor
Integration Test Coverage Report (hcd-it)
|
…results # Conflicts: # src/main/java/io/stargate/sgv2/jsonapi/api/v1/mcp/McpResource.java
This was referenced Oct 23, 2026
erichare
force-pushed
the
fix/mcp-request-context-cleanup
branch
from
October 24, 2026 00:36
f8b0f28 to
cca3d08
Compare
… into fix/mcp-readable-results # Conflicts: # src/main/java/io/stargate/sgv2/jsonapi/api/v1/mcp/McpResource.java # src/test/java/io/stargate/sgv2/jsonapi/api/v1/mcp/McpIntegrationTestBase.java # src/test/java/io/stargate/sgv2/jsonapi/api/v1/mcp/McpResourceTest.java
This was referenced Oct 27, 2026
Contributor
Author
|
Closing this after talking it through with @amorton. We don't want to send the same response twice, once in structuredContent and again as text. Clients that only show text content should read structuredContent instead, and we'll raise that with IBM Bob upstream. The rest of the MCP stack was rebuilt without this PR, so #2653 now builds directly on #2645. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Returns the complete Data API response as readable JSON text through the existing response mapper. Structured content and status metadata keep their current shapes. Serialization failures return a short tool error without payloads or exception details.
This builds on #2645.
Which issue(s) this PR fixes:
Fixes #2627. Client qualification remains in #2633.
Verification
All 19 focused tests passed with no failures, errors, or skips on this PR branch.
JAVA_HOME=/Library/Java/JavaVirtualMachines/graalvm-21.jdk/Contents/Home ./mvnw -B -ntp -Dtest=CommandResultToToolResponseTest,McpResourceTest -DskipITs -Dxml-format.skip=true testgit diff --check origin/fix/mcp-request-context-cleanup...HEADalso passed. Packaged integration tests and manual client checks were not rerun in this sweep.Checklist