Repository navigation
Conversation
This was referenced Oct 19, 2026
erichare
changed the base branch from
fix/mcp-protocol-foundation
to
fix/mcp-setup-errors
October 22, 2026 18:19
3 of 4 tasks
Contributor
📈 Unit Test Coverage Delta vs Main Branch
|
Contributor
Unit Test Coverage Report
|
Contributor
📈 Integration Test Coverage Delta vs Main Branch (dse69-it)
|
Contributor
Integration Test Coverage Report (dse69-it)
|
Contributor
📈 Integration Test Coverage Delta vs Main Branch (hcd-it)
|
Contributor
Integration Test Coverage Report (hcd-it)
|
Rebased onto fix/mcp-setup-errors without the readable-results change. Tool results keep empty text content, so McpLoggingTest reads the trace status from _meta. The serialization-failure logging test is removed because result mapping no longer serializes.
erichare
force-pushed
the
fix/mcp-safe-logging
branch
from
October 27, 2026 23:54
4917f92 to
439a80f
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Keeps MCP payloads and credentials out of logs. Completion logs and diagnostic traces share one server-generated request ID. One endpoint path controls request logging and access-log exclusion. Context propagation carries the MCP marker through driver and cache callbacks, then restores the worker context. Diagnostic stack traces expire within 15 minutes.
This builds on #2653.
Which issue(s) this PR fixes:
Fixes #2635. Deployment logging checks remain in #2634.
Verification
84 focused tests passed with 0 failures, 0 errors, and 0 skips on commit
439a80f10, and formatting checks passed. The run used port 19080 because port 9080 was bound locally. The serialization-failure logging test was removed with #2652, since result mapping no longer serializes. The MCP integration suite passed 66 of 66 at the top of the stack (fc715181f), which includes this PR.Manual client checks were not run.
Checklist