Skip to content

Describe MCP tool side effects and retry behavior - #2649

Open
erichare wants to merge 14 commits into
fix/mcp-safe-loggingfrom
fix/mcp-tool-behavior-hints
Open

erichare wants to merge 14 commits into
fix/mcp-safe-loggingfrom
fix/mcp-tool-behavior-hints

Conversation

@erichare

@erichare erichare commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

What this PR does:

Adds read, write, destructive, retry, and provider-call hints to all 35 MCP tools. An HTTP catalog test checks every published hint, and the guide documents the behavior behind the choices.

This builds on #2648.

Which issue(s) this PR fixes:

Fixes #2636.

Verification

The initial focused run hit a port-9080 conflict. Rerunning on port 19080 passed all 36 tests with 0 failures, 0 errors, and 0 skipped. Formatting checks also passed.

JAVA_HOME=/Library/Java/JavaVirtualMachines/graalvm-21.jdk/Contents/Home ./mvnw -B -ntp test -Dtest=McpToolAnnotationsTest -DskipITs -Dxml-format.skip=true -Dquarkus.http.test-port=19080

Packaged integration tests and manual client checks were not run.

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CLA Signed: DataStax CLA

@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

📈 Unit Test Coverage Delta vs Main Branch

Metric Value
Main Branch 55.07%
This PR 56.14%
Delta 🟢 +1.07%
✅ Coverage improved!

@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Unit Test Coverage Report

Overall Project 56.14% 🍏
File Coverage
GeneralCommandTools.java 22.58% 🍏
KeyspaceCommandTools.java 0% 🍏
CollectionCommandTools.java 0% 🍏

@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

📈 Integration Test Coverage Delta vs Main Branch (dse69-it)

Metric Value
Main Branch 73.04%
This PR 73.13%
Delta 🟢 +0.09%
✅ Coverage improved!

@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Integration Test Coverage Report (dse69-it)

Overall Project 73.13% 🍏
File Coverage
KeyspaceCommandTools.java 100% 🍏
CollectionCommandTools.java 100% 🍏
GeneralCommandTools.java 100% 🍏

@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

📈 Integration Test Coverage Delta vs Main Branch (hcd-it)

Metric Value
Main Branch 74.35%
This PR 74.44%
Delta 🟢 +0.09%
✅ Coverage improved!

@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Integration Test Coverage Report (hcd-it)

Overall Project 74.44% 🍏
File Coverage
KeyspaceCommandTools.java 100% 🍏
CollectionCommandTools.java 100% 🍏
GeneralCommandTools.java 100% 🍏

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MCP: Describe tool side effects and retry behavior

1 participant