Skip to content

Deprecate stellar contract bindings typescript - #2724

Merged
fnando merged 1 commit into
mainfrom
deprecate-stellar-contract-bindings-typescript
Sep 15, 2026
Merged

fnando merged 1 commit into
mainfrom
deprecate-stellar-contract-bindings-typescript

Conversation

@fnando

@fnando fnando commented Sep 15, 2026

Copy link
Copy Markdown
Member

What

Adds a deprecation warning when running stellar contract bindings typescript, pointing users to the JavaScript Stellar SDK CLI at https://github.com/stellar/js-stellar-sdk#cli. The warning is printed via Print::warnln, so it respects --quiet and goes to stderr.

Why

TypeScript bindings generation is moving to the JavaScript Stellar SDK. This gives users a clear heads-up and directs them to the supported path before the command is eventually removed.

Known limitations

N/A

Copilot AI balanced review requested due to automatic review settings September 15, 2026 18:04
@github-project-automation github-project-automation Bot moved this to Backlog (Not Ready) in DevX Sep 15, 2026
@fnando fnando self-assigned this Sep 15, 2026
@fnando fnando moved this from Backlog (Not Ready) to Needs Review in DevX Sep 15, 2026
@fnando
fnando requested a review from a team September 15, 2026 18:04
@fnando
fnando enabled auto-merge (squash) September 15, 2026 18:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread cmd/soroban-cli/src/commands/contract/bindings/typescript.rs
@fnando
fnando merged commit ce983b2 into main Sep 15, 2026
235 of 236 checks passed
@fnando
fnando deleted the deprecate-stellar-contract-bindings-typescript branch September 15, 2026 18:24
@github-project-automation github-project-automation Bot moved this from Needs Review to Done in DevX Sep 15, 2026

@leighmcculloch leighmcculloch left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One follow up:

print.warnln(
"`stellar contract bindings typescript` is deprecated. Use the JavaScript Stellar SDK \
instead: https://github.com/stellar/js-stellar-sdk#cli",
);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add to the commands doc commenet /// ⚠️ Deprecated, use X so that the deprecation shows up in the help, not only the output when running it.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call! I'll follow up on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants