Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions cmd/soroban-cli/src/commands/contract/bindings/typescript.rs
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,11 @@ impl Cmd {
pub async fn execute(&self, quiet: bool) -> Result<(), Error> {
let print = Print::new(quiet);

print.warnln(
"`stellar contract bindings typescript` is deprecated. Use the JavaScript Stellar SDK \
instead: https://github.com/stellar/js-stellar-sdk#cli",
);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add to the commands doc commenet /// ⚠️ Deprecated, use X so that the deprecation shows up in the help, not only the output when running it.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call! I'll follow up on this.

Comment thread
fnando marked this conversation as resolved.

let contract_spec::Fetched { contract, source } =
contract_spec::fetch(&self.wasm_or_hash_or_contract_id, &print).await?;

Expand Down
Loading