SDSL compiler: generic instantiations are validated in the cache, loop attributes reach the SPIR-V, a shader name as qualifier is not an instance access by Nicogo1705 · Pull Request #3389 · stride3d/stride

Nicogo1705 · 2026-09-06T15:21:12Z

PR Details

Three independent fixes to the new SDSL compiler.

An instantiated generic read back from the disk cache is validated like any other class, and keyed apart from its template

Foo<1> was served from the on-disk shader cache without the source-hash validation every plain class goes through, so an edit to the generic or to one of its bases was never seen again until the cache was deleted by hand. The validation is now a member of IExternalShaderLoader that every loader, decorators included, forwards. With no macros the cache file name also ignored the generic arguments, so Foo<1> and Foo shared one file and a template came back as an instantiation, still carrying its generic parameters. Regression test over a real on-disk cache.

`[loop]` and `[unroll]` reach the SPIR-V

A loop attribute written in SDSL was parsed and dropped, so every loop reached the backend without a loop control and FXC was free to unroll any loop whose trip count it could see; a march loop with texture fetches inside compiled in minutes. The attribute is now carried to OpLoopMerge's control mask, which SPIRV-Cross turns back into the HLSL attribute.

A shader name used as a qualifier is not an instance access

A stage method calling a static utility by its shader name - LuminanceUtils.Luma(x) from Shading(), which every post effect does - was flagged as referencing non-stage members, which forces the whole shader to be imported at root level when used in a composition. The qualifier reads no instance state; shader-kind symbols are skipped by the variable tracking.

…idated like any other class, and keyed apart from its template Foo<1> was served from the cache without the source-hash validation every plain class goes through, so an edit to the generic or to one of its bases was never seen again until the cache was deleted by hand: Stride.Voxels' walk is a generic, and a method added to its interface kept resolving to the interface's empty body in the game while the same sources built correctly in the test harness. The validation is now a member of IExternalShaderLoader that every loader, decorators included, must forward. And with no macros the cache file name ignored the generic arguments, so Foo<1> and Foo shared one file and a template came back as an instantiation, still carrying its generic parameters. Regression test over a real on-disk cache. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> (cherry picked from commit 7918de5)

A stage method calling a static utility (LuminanceUtils.Luma(x) - every post effect does it from Shading()) was flagged as referencing non-stage members, which forces the whole shader to be imported at root level when used in a composition. The flag came from the qualifier identifier: resolving `LuminanceUtils` materializes an implicit-this member access, and the tracking saw a non-stage variable read. But the identifier reads no instance state of its own, and the member access it qualifies is the method call's concern - which already exempts qualified calls. Skip shader-kind symbols in the variable tracking. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> (cherry picked from commit 699d0a2)

A loop attribute written in SDSL was parsed and dropped, so every loop went to the backend without a loop control and the HLSL compiler was free to unroll it; on a march loop with texture fetches inside that is a compile measured in minutes. The attribute is now carried through to the OpLoopMerge control mask. (cherry picked from commit 6bd06e2, without its Stride.Voxels part) Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

Nicogo1705 · 2026-09-08T15:43:28Z

Rebased on master, comments trimmed following xen2's remark on #3388 (1 to 2 lines, no history). No other change.

xen2 · 2026-09-09T02:30:22Z

        var sanitized = SanitizeName(name);
-        var macrosKey = defines.Length == 0 ? "default" : ComputeCacheFilename(generics, defines);
+        // Generic arguments are part of the key even without macros, otherwise Foo<1> and Foo share a file.
+        var macrosKey = defines.Length == 0 && generics == null ? "default" : ComputeCacheFilename(generics, defines);


You should also bump CacheFormatVersion = 2 for user who already have existing cache (otherwise they won't be invalidated and likely to crash).

xen2 · 2026-09-09T02:36:14Z

        // This forces the shader to be fully imported at root level instead of stage-only during mixin.
-        if (symbol.MemberAccessWithImplicitThis != null && !symbol.Id.IsStage && builder.CurrentFunction is { IsStage: true })
+        // A shader name used as qualifier (LuminanceUtils.Luma(x)) reads no instance state and is not tracked.
+        if (symbol.MemberAccessWithImplicitThis != null && !symbol.Id.IsStage && symbol.Id.Kind != SymbolKind.Shader


This check used to fire on the qualifier, not on the member being read. Skipping the qualifier
means nothing is left to flag this case:

shader Base { float value; } // non-stage shader Derived : Base { stage float Compute() { return Base.value; } // flagged before, not anymore }

Base.value is a real non-stage instance read, but it is compiled by the ShaderSymbol case in
AccessorChainExpression, which calls EmitSymbol directly and never goes through
CompileSymbol. So it was never tracked on its own; the qualifier was doing it by accident.

Over-flagging (the LuminanceUtils case) only costs a full import. Under-flagging can give a
stage-only import where the member is missing.

That accessor case already has field.ResolvedSymbol, so it can test IsStage on the member
itself.

xen2 · 2026-09-09T08:48:31Z

                {
                    // Double-check cache
-                    if (cache.TryLoadFromCache(className, genericArguments, macrosArray, out var buf, out var h))
+                    if (cache.TryLoadFromCache(className, genericArguments, macrosArray, out var buf, out var h) && shaderLoader.IsCachedBufferCurrent(buf))


It doesn't work completely.
I have a follow up commit that cover this, I will add it to the PR.

…n edit to it is seen

xen2 · 2026-09-09T09:10:41Z

I have added 2 commits, esp. to focus on the Builder.Class.cs caching change.
Note that:

I wrote some new tests and moved some of yours from GenericInstantiationCacheTests to ShaderDiskCacheTests
Rewrote SuppressSourceHashDoesNotLeakAcrossCacheHits into SourceHashOverrideDoesNotLeakAcrossCacheHits

Nicogo1705 and others added 3 commits September 8, 2026 16:43

Nicogo1705 mentioned this pull request Sep 8, 2026

Rendering: a shadow-caster stream for materials, and a bright pass that survives NaN #3387

Open

Review: shorter comments

108d63f

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

Nicogo1705 mentioned this pull request Sep 8, 2026

Games, Graphics, Profiling: pick the discrete GPU of a hybrid laptop, type the GPU preference, keep the profiler page at 1 or more #3388

Open

4 tasks

Nicogo1705 force-pushed the sdsl-compiler-fixes branch from 9383f72 to 108d63f Compare September 8, 2026 15:43

Nicogo1705 mentioned this pull request Sep 8, 2026

Fix voxel GI on 4.4: SDSL mixer, D3D12 root signature, Vulkan MSAA #3382

Open

8 tasks

xen2 reviewed Sep 9, 2026

View reviewed changes

xen2 added 2 commits September 9, 2026 18:02

Shaders: tests for the on-disk shader cache

2c34f66

Shaders: a MemberName instantiation records its own file's hash, so a…

529eccb

…n edit to it is seen

Navigation Menu

Uh oh!

Uh oh!

SDSL compiler: generic instantiations are validated in the cache, loop attributes reach the SPIR-V, a shader name as qualifier is not an instance access - #3389

SDSL compiler: generic instantiations are validated in the cache, loop attributes reach the SPIR-V, a shader name as qualifier is not an instance access#3389
Nicogo1705 wants to merge 6 commits into
stride3d:masterfrom
Nicogo1705:sdsl-compiler-fixes

Nicogo1705 commented Sep 6, 2026 •

edited

Loading

Uh oh!

Nicogo1705 commented Sep 8, 2026

Uh oh!

xen2 Sep 9, 2026

Uh oh!

xen2 Sep 9, 2026

Uh oh!

xen2 Sep 9, 2026

Uh oh!

xen2 commented Sep 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

Nicogo1705 commented Sep 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Details

An instantiated generic read back from the disk cache is validated like any other class, and keyed apart from its template

[loop] and [unroll] reach the SPIR-V

A shader name used as a qualifier is not an instance access

Related

Uh oh!

Nicogo1705 commented Sep 8, 2026

Uh oh!

xen2 Sep 9, 2026

Choose a reason for hiding this comment

Uh oh!

xen2 Sep 9, 2026

Choose a reason for hiding this comment

Uh oh!

xen2 Sep 9, 2026

Choose a reason for hiding this comment

Uh oh!

xen2 commented Sep 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Nicogo1705 commented Sep 6, 2026 •

edited

Loading

`[loop]` and `[unroll]` reach the SPIR-V