External Storage Integration: Activity worker, client - #3020
Open
cconstable wants to merge 1 commit into
Open
Conversation
cconstable
changed the title
cconstable
commented
Aug 19, 2026
Comment on lines
+145
to
+148
| public ListWorkflowExecutionsResponse listWorkflowExecutions( | ||
| ListWorkflowExecutionsRequest listRequest) { | ||
| return next.listWorkflowExecutions(listRequest); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Addressed the previous concern of eagerly fetching external payloads #2978 (comment). They are now loaded lazily.
cconstable
force-pushed
the
extstore/activity-client
branch
from
August 19, 2026 18:45
37ae3c7 to
7069249
Compare
cconstable
commented
Aug 19, 2026
|
|
||
| try { | ||
| sendReply(taskToken, result, metricsScope); | ||
| sendReply(taskToken, result, metricsScope, activityStorageTarget(pollResponse)); |
Contributor
Author
There was a problem hiding this comment.
Previous comment about pivoting this target based on standalone vs workflow activity has been addressed #2978 (comment)
activityStorageTarget delegates to storageTargetForActivityTask (which can be seen above)
cconstable
marked this pull request as ready for review
August 19, 2026 18:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
WorkflowClientInternalImpl,HeartbeatContextImpl, andActivityWorker.Why?
Checklist