Repository navigation
Separate RowFn batch inspection from execution planning - #10673
connortsui20 wants to merge 1 commit into
Conversation
Merging this PR will degrade performance by 15.14%3 warnings, 1 note
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing Footnotes
|
5541df9 to
abc8689
Compare
80cbea7 to
9663585
Compare
Inspect borrowed inputs once for lengths, dtypes, constant classification, and strict validity. Pair collected inputs with a separate execution plan while retaining the existing dispatch and retry paths. Extracted from #9979. Signed-off-by: Robert Kruszewski <github@robertk.io> Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
abc8689 to
d3afc24
Compare
Summary
Extracts batch setup from #9979 into a private borrowed-input boundary. Input lengths, dtypes, constants, and strict validity are inspected together before attaching the dispatch-selected execution plan.
Targets
developand can merge independently. #10675 and #10676 use the borrowed batch entry point introduced here.Changes
Keeps constant classification, input ownership, and execution metadata inside the framework. General execution still collects owned inputs and uses the existing dispatch and retry paths. Function IDs are deferred during inspection until an error needs them, with the supporting
CachedIdinlining change kept here.The Vortex test suite was not run locally. Focused native measurements of the combined migration were run separately during the compiler investigation.