Repository navigation
Compare primitive values through the shared RowFn executor - #10676
connortsui20 wants to merge 1 commit into
Conversation
Merging this PR will regress 6 benchmarks4 warnings, 1 note
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing Footnotes
|
dee1a57 to
3a38935
Compare
3a38935 to
33ccf9b
Compare
Keep the primitive kernel focused on type and operator dispatch. Delegate borrowed inputs, constants, strict validity, and packed Boolean output to the lower stack layers while preserving Binary identity and floating-point total ordering. Replaces the comparison migration in #9979. Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
33ccf9b to
b837021
Compare
Summary
Replaces the primitive comparison migration in #9979, using the shared executor from #10675. This PR depends on #10675, which is deferred until the independent foundations #10672, #10673, and #10674 merge.
Changes
The private row kernel selects the primitive type and comparison operator. The framework owns borrowed inputs, constant handling, strict validity, and packed Boolean output. Removes the primitive operand wrapper and handwritten primitive kernels while preserving the public
Binaryidentity and Vortex's floating-point total ordering.Native Graviton3 measurements showed regressions when this migration used only #10673. Removing only the fused-execution patch while keeping all three foundations also slowed the tested comparisons. The dependency on #10675 keeps that execution work available when this migration merges.
Existing comparison tests exercise the shared executor. The Vortex test suite was not run locally. Compiler investigation checks and focused native comparison measurements were run separately.