New C++ api by myrrc · Pull Request #8651 · vortex-data/vortex

myrrc · 2026-07-03T16:12:16Z

Replace C++ api with a new one which depends on vortex-ffi.
Remove cxx crate from workspace.
Port FFI examples and tests to C++ examples as tests.
Add a reader/writer guide for C++ api.
Run C++ tests with ASAN and run examples in CI.

FFI changes:

Add vx_expression_clone
Remove accidental const modifier from output from vx_expression_not
Fix a memory leak in vx_struct_fields_builder_add_field where a non-UTF8 field throws before DType was converted from a raw pointer to an Arc

codspeed-hq · 2026-07-03T16:22:54Z

Merging this PR will not alter performance

⚠️

Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️

Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 2 improved benchmarks
❌ 2 regressed benchmarks
✅ 1664 untouched benchmarks
⏩ 4 skipped benchmarks¹

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

	Mode	Benchmark	`BASE`	`HEAD`	Efficiency
❌	Simulation	`chunked_varbinview_into_canonical[(1000, 10)]`	170 µs	206.1 µs	-17.52%
❌	Simulation	`compare_int_constant`	268.4 µs	298.5 µs	-10.08%
⚡	Simulation	`chunked_varbinview_canonical_into[(1000, 10)]`	190.4 µs	154.5 µs	+23.18%
⚡	Simulation	`bitwise_not_vortex_buffer_mut[128]`	273.6 ns	244.4 ns	+11.93%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.

_{Comparing myrrc/cxx2 (347b89d) with develop (dd4ab89)}

4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

0ax1

first pass

0ax1 · 2026-07-08T16:07:10Z

+     * Estimated count. Throws if not known(). For inexact estimates this is
+     * is an upper bound.
+     */
+    uint64_t value() const;


Not sure I understand this API. Why not just have value? What's the flow when the caller passes in the fallback. And why does that need to handled in a method of Estimate?

0ax1 · 2026-07-08T16:07:57Z

+
+    // List accessors. Valid only on List and FixedSizeList dtypes
+
+    DataType list_element() const;


Every public fn in this PR added needs docs.

0ax1

second pass

0ax1 · 2026-07-08T16:25:19Z

+
+private:
+    void reset() noexcept {
+        if (!path_.empty()) {


Do we care about checking the error in tests?

0ax1 · 2026-07-08T16:51:56Z

+    return BytesView(std::move(canonical), std::move(validity), n);
+}
+
+Array make_struct(


Why actually not && in the signature for the return type?

0ax1 · 2026-07-08T16:54:43Z

+}
+
+void StructArrayBuilder::Deleter::operator()(
+    vx_struct_column_builder* ptr) const noexcept {


What's our rule of thumb for sprinkling noexcept?

0ax1 · 2026-07-08T16:56:19Z

+        }
+        session_ = std::move(other.session_);
+        stream_ = other.stream_;
+        other.stream_ = ArrowArrayStream{};


Also here we do why change other? other.stream_ = ArrowArrayStream{};

Signed-off-by: Mikhail Kot <mikhail@spiraldb.com>

myrrc added the changelog/break A breaking API change label Jul 3, 2026

myrrc force-pushed the myrrc/cxx2 branch 2 times, most recently from 05babc3 to 5795c45 Compare July 3, 2026 16:35

myrrc requested a review from 0ax1 July 3, 2026 16:47

myrrc force-pushed the myrrc/cxx2 branch 2 times, most recently from a044015 to a5c7567 Compare July 3, 2026 16:56

myrrc added the lang/cpp Relates to the Vortex C++ API label Jul 7, 2026

myrrc force-pushed the myrrc/cxx2 branch 8 times, most recently from 66bfb31 to de2512a Compare July 8, 2026 14:07

0ax1 reviewed Jul 8, 2026

View reviewed changes

vortex-data deleted a comment from github-actions Bot Jul 8, 2026

0ax1 reviewed Jul 8, 2026

View reviewed changes

myrrc force-pushed the myrrc/cxx2 branch from 46cf4f5 to 347b89d Compare July 10, 2026 14:17

myrrc requested a review from 0ax1 July 10, 2026 14:19

initial

2ba494e

Signed-off-by: Mikhail Kot <mikhail@spiraldb.com>

myrrc force-pushed the myrrc/cxx2 branch from 347b89d to 2ba494e Compare July 10, 2026 14:43


		// List accessors. Valid only on List and FixedSizeList dtypes

		DataType list_element() const;

Uh oh!

Conversation

myrrc commented Jul 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codspeed-hq Bot commented Jul 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Performance Changes

Footnotes

Uh oh!

0ax1 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

0ax1 Jul 8, 2026

Choose a reason for hiding this comment

Uh oh!

0ax1 Jul 8, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

0ax1 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

0ax1 Jul 8, 2026

Choose a reason for hiding this comment

Uh oh!

0ax1 Jul 8, 2026

Choose a reason for hiding this comment

Uh oh!

0ax1 Jul 8, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

0ax1 Jul 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

myrrc commented Jul 3, 2026 •

edited

Loading

codspeed-hq Bot commented Jul 3, 2026 •

edited

Loading

0ax1 Jul 8, 2026 •

edited

Loading