[don't merge] New C++ api

.clang-format

@@ -25,7 +25,7 @@ DerivePointerAlignment: false
 IncludeBlocks: Regroup
 InsertBraces: true
 Language: Cpp
-NamespaceIndentation: Inner
+NamespaceIndentation: None
 PointerAlignment: Right
 SpaceBeforeCpp11BracedList: true
 SpaceBeforeCtorInitializerColon: true

vortex-cxx/.clang-tidy → .clang-tidy

@@ -1,5 +1,5 @@
-#  SPDX-License-Identifier: Apache-2.0
-#  SPDX-FileCopyrightText: Copyright the Vortex contributors
+# SPDX-License-Identifier: Apache-2.0
+# SPDX-FileCopyrightText: Copyright the Vortex contributors
 
 Checks: |
   -*,
@@ -43,7 +43,7 @@ Checks: |
   -bugprone-unused-local-non-trivial-variable,
   -bugprone-empty-catch,
 WarningsAsErrors: '*'
-HeaderFilterRegex: '(cpp|examples)/.*\.(cpp|hpp)$'
+HeaderFilterRegex: '(examples)/.*\.(cpp|hpp)$'
 FormatStyle:     none
 CheckOptions:
   - key:             readability-identifier-naming.ClassCase
@@ -90,4 +90,3 @@ CheckOptions:
     value:           lower_case
   - key:             cppcoreguidelines-rvalue-reference-param-not-moved.IgnoreUnnamedParams
     value:           true
-

.github/workflows/ci.yml

@@ -523,8 +523,8 @@ jobs:
           command: check ${{ matrix.checks }}
 
   cxx-test:
-    name: "C++ build"
-    timeout-minutes: 30
+    name: "C++ API tests"
+    timeout-minutes: 5
     runs-on: >-
       ${{ github.repository == 'vortex-data/vortex'
           && format('runs-on={0}/runner=amd64-medium/image=ubuntu24-full-x64-pre-v2/extras=s3-cache/tag=cxx-build', github.run_id)
@@ -538,20 +538,42 @@ jobs:
       - uses: ./.github/actions/setup-prebuild
         with:
           enable-sccache: "true"
-      - name: Build and run C++ unit tests
+      - name: Install Rust nightly toolchain
+        run: |
+          rustup toolchain install $NIGHTLY_TOOLCHAIN
+          rustup component add --toolchain $NIGHTLY_TOOLCHAIN rust-src rustfmt clippy llvm-tools-preview
+      - name: Build FFI library (asan)
+        run: |
+          RUSTFLAGS="-A warnings -Cunsafe-allow-abi-mismatch=sanitizer \
+                -C debuginfo=2 -C opt-level=0 -C strip=none -Zexternal-clangrt \
+                -Zsanitizer=address,leak" \
+          cargo +$NIGHTLY_TOOLCHAIN build --locked --no-default-features \
+            --target x86_64-unknown-linux-gnu -Zbuild-std \
+            -p vortex-ffi
+      - name: Build C++ tests (asan)
         run: |
           mkdir -p vortex-cxx/build
-          cmake -S vortex-cxx -B vortex-cxx/build -DVORTEX_ENABLE_TESTING=ON -DVORTEX_ENABLE_ASAN=ON
+          cmake -S vortex-cxx -B vortex-cxx/build -DBUILD_TESTS=ON -DSANITIZER=asan -DTARGET_TRIPLE="x86_64-unknown-linux-gnu"
           cmake --build vortex-cxx/build --parallel $(nproc)
-          ctest --test-dir vortex-cxx/build -j $(nproc) -V
-      - name: Build and run the example in release mode
+      - name: Run C++ tests
+        run: |
+          vortex-cxx/build/tests/vortex_cxx_test
+      - name: Build and run examples
         run: |
-          cmake -S vortex-cxx/examples -B vortex-cxx/examples/build -DCMAKE_BUILD_TYPE=Release
+          cmake -S vortex-cxx -B vortex-cxx/examples/build -DSANITIZER=asan -DBUILD_EXAMPLES=1 -DTARGET_TRIPLE="x86_64-unknown-linux-gnu"
           cmake --build vortex-cxx/examples/build --parallel $(nproc)
-          vortex-cxx/examples/build/hello-vortex vortex-cxx/examples/goldenfiles/example.vortex
-      - uses: ./.github/actions/check-rebuild
-        with:
-          command: "cargo build --profile ci --locked -p vortex-cxx --lib"
+          cd vortex-cxx/examples/build/examples
+          # filesystem loop detected
+          rm -fr ../_deps/nanoarrow-src/python/subprojects/arrow-nanoarrow
+
+          ./writer people0.vortex
+          ./writer people1.vortex
+          ./writer me.vortex
+
+          ./scan '*.vortex'
+          ./dtype me.vortex
+
+          ./reader
 
   sqllogic-test:
     name: "SQL logic tests"

Cargo.toml

@@ -32,7 +32,6 @@ members = [
     "vortex-cuda/gpu-scan-cli",
     "vortex-cuda/macros",
     "vortex-cuda/nvcomp",
-    "vortex-cxx",
     "vortex-ffi",
     "fuzz",
     "vortex-jni",

docs/Doxyfile.cpp

@@ -5,7 +5,7 @@ PROJECT_NAME           = "Vortex C++"
 OUTPUT_DIRECTORY       = _build/doxygen-cpp
 
 # Input sources
-INPUT                  = ../vortex-cxx/cpp/include/vortex
+INPUT                  = ../vortex-cxx/include/vortex
 FILE_PATTERNS          = *.hpp
 RECURSIVE              = NO
 
@@ -26,6 +26,3 @@ MACRO_EXPANSION        = NO
 
 # Suppress warnings about undocumented members (WIP API)
 WARN_IF_UNDOCUMENTED   = NO
-
-# Exclude cxx bridge internals from documentation
-EXCLUDE_SYMBOLS        = ffi::*