Improved Laravel 13 Support [Minimal PR] - #246
Open
austinderrick wants to merge 1 commit into
Open
austinderrick wants to merge 1 commit into
austinderrick wants to merge 1 commit into
Conversation
- Allow laravel/framework ^13, laravel/tinker ^3 and orchestra/testbench ^11 next to the Laravel 12 versions. - ArraySource: build the SQLite datasource on first use instead of in bootArraySource(). Laravel 13 throws when a model is instantiated while it is booting. Boot still clears the connection, so clearBootedModels() rebuilds it. - PHPStan baseline: match the MailFake::queue() signature on both 12 and 13. - Clone the arraysubset-asserts VCS repo without the GitHub API, so fork PR CI can install.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 24, 2026
austinderrick
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lets Storm install on Laravel 13 without dropping Laravel 12. This is the slimmed-down alternative to #228.
laravel/framework,laravel/tinkerandorchestra/testbenchto accept the Laravel 13 versions. PHP stays at^8.2, so the 8.2 CI job keeps testing Laravel 12 and 8.3+ tests 13.ArraySourcebuilt its SQLite datasource inbootArraySource(), which doesnew static. Laravel 13 throws aLogicExceptionif a model is created while it's still booting, so the datasource is now built the first time the connection is resolved. Boot still resets it, soclearBootedModels()behaves the same as before.MailFake::queue()baseline entry now matches the signature on both 12 and 13.no-apito the arraysubset-asserts repo so CI on fork PRs can install without a token.The full suite passes locally on Laravel 12.69 and 13.33.
IMPORTANT THINGS:
MarkdownTest'ssimple_tablecase fails on any fresh install right now because ofleague/commonmark2.10.2+, with or without this PR. This is resolved in Fix the simple_table Markdown test for league/commonmark 2.10.2 #247.