Skip to content

Pipeline Repair: Fix the simple_table Markdown test for league/commonmark 2.10.2 - #247

Open
austinderrick wants to merge 1 commit into
wintercms:developfrom
austinderrick:fix/commonmark-gfm-tables
Open

austinderrick wants to merge 1 commit into
wintercms:developfrom
austinderrick:fix/commonmark-gfm-tables

Conversation

@austinderrick

@austinderrick austinderrick commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

MarkdownTest's simple_table case fails on any fresh install right now, on every branch.

league/commonmark 2.10.2 changed table detection to match the GFM spec: a header row no longer needs a |. So this block in the fixture, which we expected to stay a paragraph, is now a one-column table (GitHub renders it the same way):

header 1
-------|
cell 1.1
  • Updated the fixture to expect a table for that case.
  • Required league/commonmark ^2.10.2 so the result doesn't depend on which release gets installed. 2.10.2 is also a security release.

wip/1.3 has the same fixture and will pick this up when develop is merged forward.

@coderabbitai

coderabbitai Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 5a22dd82-2bb0-471f-91a3-b8826e6975fa

📥 Commits

Reviewing files that changed from the base of the PR and between 7b4f4e7 and 5f13d7e.

📒 Files selected for processing (3)
  • composer.json
  • tests/fixtures/markdown/simple_table.html
  • tests/fixtures/markdown/simple_table.md

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

The required dependencies now include league/commonmark at version ^2.10.2. The Markdown fixture label changes from “Not a table.” to “Is a table.” Its expected HTML changes from a single paragraph to a paragraph followed by a one-column table with two body rows.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 5f13d

The dependency constraint and expected table output align with the stated behavior; the change is mergeable after normal checks.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the simple_table Markdown fixture fix and the league/commonmark 2.10.2 version involved. It is concise and directly related to the pull request changes.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@austinderrick austinderrick changed the title Fix the simple_table Markdown test for league/commonmark 2.10.2 Pipeline Repair: Fix the simple_table Markdown test for league/commonmark 2.10.2 Sep 24, 2026
league/commonmark 2.10.2 aligned table detection with the GFM spec: a header row no longer needs a
pipe, so "header 1" followed by "-------|" is now a one-column table. Update the fixture to expect
a table there, and require ^2.10.2 so the output does not depend on which release is installed
(2.10.2 is also a security release).
@austinderrick
austinderrick force-pushed the fix/commonmark-gfm-tables branch from 989b01d to 5f13d7e Compare September 24, 2026 01:47
@austinderrick
austinderrick changed the base branch from wip/1.3 to develop September 24, 2026 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant