Pipeline Repair: Fix the simple_table Markdown test for league/commonmark 2.10.2 - #247
austinderrick wants to merge 1 commit into
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. WalkthroughThe required dependencies now include Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The dependency constraint and expected table output align with the stated behavior; the change is mergeable after normal checks. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
league/commonmark 2.10.2 aligned table detection with the GFM spec: a header row no longer needs a pipe, so "header 1" followed by "-------|" is now a one-column table. Update the fixture to expect a table there, and require ^2.10.2 so the output does not depend on which release is installed (2.10.2 is also a security release).
989b01d to
5f13d7e
Compare
MarkdownTest'ssimple_tablecase fails on any fresh install right now, on every branch.league/commonmark 2.10.2 changed table detection to match the GFM spec: a header row no longer needs a
|. So this block in the fixture, which we expected to stay a paragraph, is now a one-column table (GitHub renders it the same way):league/commonmark ^2.10.2so the result doesn't depend on which release gets installed. 2.10.2 is also a security release.wip/1.3has the same fixture and will pick this up whendevelopis merged forward.