Skip to content

Recompute mutual-follow bits on cached For You posts - #175

Open
Pitchfork-and-Torch wants to merge 1 commit into
xai-org:mainfrom
Pitchfork-and-Torch:cursor/cache-hit-stale-mutual-follow-6d66
Open

Recompute mutual-follow bits on cached For You posts#175
Pitchfork-and-Torch wants to merge 1 commit into
xai-org:mainfrom
Pitchfork-and-Torch:cursor/cache-hit-stale-mutual-follow-6d66

Conversation

@Pitchfork-and-Torch

Copy link
Copy Markdown

Bug

BidirectionalFollowHydrator.enable was flag && !has_cached_posts.

FollowedUserIdsQueryHydrator still runs on a cache hit. The follow list is current. RankingScorer still runs. It reads is_mutual_follow_author and, when that bit is Some(true), adds BidirectionalFollowReplyWeightBoost to the reply head. That boost defaults to 15.0 on a ReplyWeight of 5.0.

Skipping the hydrator keeps the bit written up to 180s earlier. A new mutual does not get the boost. A broken mutual keeps a 4x reply-head weight. PhoenixScorer is also skipped on the cache hit, so the weighted score is rebuilt from cached phoenix heads times the stale bit.

CachedPostsQueryHydrator sets has_cached_posts when Redis returns at least 500 posts. TTL is 180s.

This is not #135 (in_network bit). Not #156 (block / nsfw_author / quote).

Five-line proof

Fix

Enable whenever the hydration flag is on. update overwrites the cached bits.

Tests

  • enable is true on cache hit and miss
  • cache-hit hydrate + update: author no longer follows viewer -> Some(false)
  • cache-hit hydrate + update: viewer unfollowed -> Some(false)
  • cache-hit hydrate + update: newly mutual -> Some(true)

RankingScorer test bidirectional_weight_boosts_only_mutual_original_posts is the score sink.

cargo test cannot run here. Public dump has no Home Mixer manifest.

BidirectionalFollowHydrator skipped cache hits, so RankingScorer kept
applying the default +15 reply-head boost from a stale
is_mutual_follow_author bit for up to 180s.

Co-authored-by: Jon Bailey <Pitchfork-and-Torch@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants