Repository navigation
Preserve dictionary errors in case-insensitive mappings - #96
Open
ShahadatTest wants to merge 2 commits into
Open
ShahadatTest wants to merge 2 commits into
ShahadatTest wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CaseInsensitiveDict.pop currently supplies an implicit None default, so removing a missing key silently succeeds. update(42) raises UnboundLocalError while trying to build its intended TypeError message. Distinguish an omitted pop default with a private sentinel, preserving explicit defaults passed positionally or with
default=, and use the actual source object when reporting unsupported updates.Both regressions fail before the fix. Explicit None/object defaults and existing differently-cased keys are covered. On Windows/Python 3.12 the full suite reports 65 passed, 6 failed, compared with 63 passed, the same 6 failed on unmodified master. These existing failures concern CLI subprocesses, HOME/path handling, warning hooks and terminal mocks. All 4 case-insensitive tests pass on Python 3.10. Configured Flake8 (including docstrings) and diff checks pass. Other supported runtimes were not run.
Prepared with OpenAI Codex (GPT-6) assistance for
new 20ta koro(make 20 new contributions). Investigation, implementation and tests were AI-assisted; no personal production use or human code review is claimed.