Skip to content

Fix native addon CI failure by upgrading gyp C++ standard to C++17 - #30

Merged
yushulx merged 2 commits into
mainfrom
copilot/fix-ci-build-failure-95299240334
Aug 17, 2026
Merged

yushulx merged 2 commits into
mainfrom
copilot/fix-ci-build-failure-95299240334

Conversation

Copilot AI commented Aug 17, 2026 •

Copy link
Copy Markdown
Contributor

CI job 95299240334 failed because node-addon-api headers now require C++17 features, while the addon target was compiled as C++11. This change aligns addon compile flags with the required standard for Linux and macOS builds.

  • Root cause

    • binding.gyp set -std=c++11 for Linux/macOS cflags and cflags_cc, which is incompatible with current node-addon-api usage (std::string_view, std::void_t).
  • Change made

    • Updated addon compile standard in binding.gyp:
      • Linux: cflags, cflags_cc → -std=c++17
      • macOS: cflags, cflags_cc → -std=c++17
  • Scope guard

    • No workflow/toolchain version changes.
    • No unrelated source or behavior changes.
- "cflags": ["-std=c++11", ...],
- "cflags_cc": ["-std=c++11", ...],
+ "cflags": ["-std=c++17", ...],
+ "cflags_cc": ["-std=c++17", ...],

Co-authored-by: yushulx <2202306+yushulx@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix CI build failure due to C++ standard mismatch Fix native addon CI failure by upgrading gyp C++ standard to C++17 Aug 17, 2026
Copilot AI requested a review from yushulx August 17, 2026 06:27
@yushulx
yushulx marked this pull request as ready for review August 17, 2026 06:28
@yushulx
yushulx merged commit 6ceca47 into main Aug 17, 2026
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants