Skip to content

feat(launchpad): dashboards store their filter hierarchies - #1495

Merged
rubenvdlinde merged 3 commits into
developmentfrom
feat/drill-down-cross-widget-filter-stored-hierarchies
Nov 21, 2026
Merged

rubenvdlinde merged 3 commits into
developmentfrom
feat/drill-down-cross-widget-filter-stored-hierarchies

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

What

Dashboards store the hierarchy descriptors their filter bus joins widgets on (drill-down-cross-widget-filter, new REQ-CWF-011; Ruben 21 Nov 2026).

  • Nullable hierarchies JSON column on launchpad_dashboards (migration Version002017Date20261121000000, app version bumped), on the Dashboard entity and its owner and viewer reads ([] when none).
  • PUT /api/dashboard/{id} accepts hierarchies. It needs the full edit permission, like a layout change. DashboardHierarchies::validated() refuses a malformed descriptor with 400 before anything is saved (not a list, no id, no or too many levels, bad dimension, repeated dimension or id, wrong parentDimension) and derives each level's parent from the level above.
  • openapi.json documents the field (through scripts/openapi-overlay.json).
  • e2e: tests/e2e/dashboard-hierarchies.spec.ts covers store/read, refusal, view-only refusal, clearing and the bus reading the stored hierarchy. cross-widget-filter-performance.spec.ts now stores the nl-administrative hierarchy through the API; the page.route injection on the dashboard read is gone.
  • Spec: REQ-CWF-011 with five scenarios; tasks 36-41 added, 36, 37 and 41 ticked.

The settings UI and the preset module follow in the next PR.

Verified locally (CI bottleneck, merged on local green)

  • hydra/scripts/diff-check.sh: no NEW findings in php -l, phpcs, phpstan, phpmd, phpunit, eslint. Gates: one finding in gate-23 (or-abstraction, app-local Tenant classes in TenantTheme*), files this PR does not touch, so inherited.
  • composer check:strict once: PHPUnit 5555 tests OK (13 skipped), phpstan OK, lint/openapi/spec-annotations/licenses OK. The phpcs and phpmd findings are all on files or lines this PR does not touch. Psalm cannot run on this host (needs PHP 8.3.16, host has 8.3.6).
  • The e2e specs were not run here (no instance in this lane); the live-pass lane runs them.

Inherited: phpcs findings in the existing DashboardApiControllerUpdateAccessTest.php and DashboardSerializeGoldenTest.php (positional PHPUnit arguments), and two phpmd findings in lib/Db/Dashboard.php.

AI assistance: built with Claude Code (claude-opus-5-5).

A dashboard now stores the hierarchy descriptors its filter bus joins
widgets on (REQ-CWF-011): a nullable `hierarchies` JSON column on
launchpad_dashboards, returned on the owner and viewer reads as a list
([] when none). PUT /api/dashboard/{id} accepts `hierarchies`, which
needs the full edit permission like a layout change; the new
DashboardHierarchies validator refuses a malformed descriptor with 400
before anything is saved and derives each level's parent from the level
above. openapi documents the field; the goldens carry the new wire
field. The change gets REQ-CWF-011 and tasks 36-41.

Assisted-by: ClaudeCode:claude-opus-5-5
tests/e2e/dashboard-hierarchies.spec.ts covers REQ-CWF-011 through the
dashboard API: stored and read back, refused when malformed or sent by a
view-only recipient, cleared by an empty list, and read by the filter
bus of the open dashboard. The performance spec stores the
nl-administrative hierarchy through the API instead of adding it to the
dashboard read.

Assisted-by: ClaudeCode:claude-opus-5-5
@rubenvdlinde
rubenvdlinde merged commit 1ee9aae into development Nov 21, 2026
8 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/launchpad @ e7050b2

Check PHP Vue Security License Tests
lint ✅
phpcs ❌
phpmd ❌
psalm ❌
phpstan ✅
phpmetrics ✅
eslint ✅
stylelint ✅
build ✅
check-manifest ✅
format ❌
check-schema-l10n ❌
composer ❌ ✅ 127/127
npm ✅ ✅ 647/647
app:check-code ⏭️
info.xml ✅
REUSE ❌
lockfile sync ✅
PHPUnit ❌
Newman ❌
Playwright ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development.
Hydra gates ❌

Quality workflow — 2026-11-21 19:39 UTC

Download the full PDF report from the workflow artifacts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant