Repository navigation
fix(web): status pages pass the design lint - #2014
Conversation
The status-pages stack landed after the design rules became lint (#2002), so main's effect-lint fails on 11 errors. Map each onto the token it names: radius tokens for hand-picked corners, active: twins for hover states, tone alpha steps (-a1, -a4) for /NN tones, shadow-popup for the floating save bar.
Maple review🟢 Confidence 10/10 · safe to merge. Six class-string swaps, each verified equal to the token it now names in Replaces hand-picked values in the status-pages views with the design-system tokens the lint names (radii, tone alpha steps,
|
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Status-page view style updates apps/web/src/page/status-pages/builder/view.ts, apps/web/src/page/status-pages/editor/view-canvas.ts, apps/web/src/page/status-pages/editor/view-live.ts, apps/web/src/page/status-pages/editor/view-settings.ts, apps/web/src/page/status-pages/list/view.ts, apps/web/src/page/status-pages/shared/look.ts |
The views update shadow, color, border, and corner-radius utilities. Editor and list elements also add or adjust active-state styles. |
Estimated code review effort: 2 (Simple) | ~7 minutes
Change: Other
Possibly related PRs
- MapleTechLabs/maple#1938: Introduced the themeable status-page editor and appearance controls that this PR updates.
- MapleTechLabs/maple#1999: Replaced arbitrary styling values with design tokens in web UI code, similar to this PR’s utility updates.
- MapleTechLabs/maple#1950: Created the status-page views changed by this PR.
Suggested labels: preview:web
Merge Risk: 
0818a
-
No actionable merge-blocking risk remains in the reviewed styling changes.
Pre-merge checks: 
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly identifies the web status-pages changes and the primary objective of making them pass the design lint. Docstring Coverage No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 6 files.
-
Finishing Touches
-
Generate docstrings
-
- Commit to this branch
- Create a new PR
Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
main's TypeScript (effect-lint) job fails on 11 errors inapps/web/src/page/status-pages/. The status-pages stack (#1950, #1972) merged after #2002 turned the design rules into lint, so every PR inherits the failure (seen on #2013).Each error maps to the token the rule names, at the same or a near-identical value:
rounded-[2px]→rounded-xs,rounded-[1px]→rounded-2xs(1px)active:twins (4 places)border-destructive/40→border-destructive-a4(40%),bg-primary/5→bg-primary-a1(6%)shadow-lg→shadow-popupon the floating save barVerified:
oxlint -c .oxlintrc.effect.json --quiet apps/webexits 0 (was 11 errors). No layout change; values are token equivalents.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by CodeRabbit