Skip to content

fix(web): status pages pass the design lint #2014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JeremyFunk merged 1 commit into from
Oct 31, 2026
Merged

fix(web): status pages pass the design lint #2014

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/web/src/page/status-pages/builder/view.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ const footerBar = (h: H, model: Model): Html => {
return h.div(
[
h.Class(
"sticky bottom-4 z-10 flex flex-wrap items-center justify-between gap-3 rounded-lg border bg-popover py-2 pr-2 pl-4 shadow-lg",
"sticky bottom-4 z-10 flex flex-wrap items-center justify-between gap-3 rounded-lg border bg-popover py-2 pr-2 pl-4 shadow-popup",
),
],
[
Expand Down
4 changes: 2 additions & 2 deletions apps/web/src/page/status-pages/editor/view-canvas.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ const statusDot = (h: H, status: StatusPageComponentStatus): Html =>
[
h.AriaHidden(true),
h.Class(
cn("inline-block size-2 shrink-0 rounded-[2px]", TONE_FILL[COMPONENT_STATUS_TONE[status]]),
cn("inline-block size-2 shrink-0 rounded-xs", TONE_FILL[COMPONENT_STATUS_TONE[status]]),
),
],
[],
Expand All @@ -125,7 +125,7 @@ const itemClass = (isSelected: boolean) =>
"flex min-w-0 flex-1 items-center gap-2 rounded-md px-2 py-1.5 text-left text-sm transition-colors outline-none focus-visible:ring-2 focus-visible:ring-ring",
isSelected
? "bg-muted font-medium text-foreground"
: "text-muted-foreground hover:bg-muted/50 hover:text-foreground",
: "text-muted-foreground hover:bg-muted/50 hover:text-foreground active:bg-muted/50 active:text-foreground",
)

const componentItem = (
Expand Down
2 changes: 1 addition & 1 deletion apps/web/src/page/status-pages/editor/view-live.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export const addressLine = (h: H, model: Model, page: V2StatusPage): Html => {
h.Target("_blank"),
h.Rel("noopener"),
h.Class(
"font-mono text-xs text-muted-foreground underline-offset-2 hover:text-foreground hover:underline",
"font-mono text-xs text-muted-foreground underline-offset-2 hover:text-foreground hover:underline active:text-foreground active:underline",
),
],
[url],
Expand Down
2 changes: 1 addition & 1 deletion apps/web/src/page/status-pages/editor/view-settings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ const breakGlassSection = (h: H, model: Model, page: V2StatusPage): Html => {

const dangerZone = (h: H): Html =>
settingsSection(h, { id: "status-page-settings-danger", title: "Danger zone", framed: false }, [
panel(h, { className: "border-destructive/40" }, [
panel(h, { className: "border-destructive-a4" }, [
h.div(
[h.Class("flex items-start justify-between gap-6 p-4")],
[
Expand Down
2 changes: 1 addition & 1 deletion apps/web/src/page/status-pages/list/view.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ const lastPublished = (h: H, summary: StatusPageSummary, inputs: ViewInputs): Ht
const pageRow = (h: H, summary: StatusPageSummary, inputs: ViewInputs): Html => {
const page = summary.page
return h.li(
[h.Key(page.id), h.Class("relative py-3 pr-4 pl-4 hover:bg-muted/25")],
[h.Key(page.id), h.Class("relative py-3 pr-4 pl-4 hover:bg-muted/25 active:bg-muted/25")],
[
h.div(
[h.Class(ROW_GRID)],
Expand Down
4 changes: 2 additions & 2 deletions apps/web/src/page/status-pages/shared/look.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ const presetCard = <M>(
h.span(
[h.Class("flex gap-0.5")],
[scheme.ok, scheme.ok, scheme.degraded, scheme.ok].map((color) =>
h.span([h.Class("h-2 w-1.5 rounded-[1px]"), h.Style({ backgroundColor: color })], []),
h.span([h.Class("h-2 w-1.5 rounded-2xs"), h.Style({ backgroundColor: color })], []),
),
),
],
Expand All @@ -60,7 +60,7 @@ const presetCard = <M>(
h.Class(
cn(
"flex flex-col gap-1.5 rounded-lg border p-1.5 text-left text-xs transition-colors disabled:cursor-not-allowed disabled:opacity-60",
isSelected ? "border-primary/70 bg-primary/5" : "hover:bg-muted/50",
isSelected ? "border-primary/70 bg-primary-a1" : "hover:bg-muted/50 active:bg-muted/50",
),
),
],
Expand Down
Loading