Repository navigation
Conversation
Read literal Prefix delegation and URI concatenation in RouteDecorator implementations, using the declaring namespace and PHP member precedence. Apply method decorators before class decorators for route completion, navigation, and parameter references and renames. Keep built-in URI prefixes precomputed and memoize custom decorators within each request. Cover supported bodies, recovery, namespace collisions, inherited methods, unsaved edits, and literal slash behavior.
Add Admin and Versioned decorators to the playground and verify their combined URI with Tempest's own discovery and URI generator. Document the behavior, credit the contribution, and remove the completed roadmap item.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
shuvroroy
marked this pull request as ready for review
November 9, 2026 04:21
This was referenced Nov 9, 2026
Closed
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Custom Tempest route decorators now contribute their literal URI prefixes, so a call such as
uri('/admin/v1/books/{book}', book: 'php')completes and navigates to the controller action and its parameter. URI parameter references and renames follow the decorated path too.The implementation preserves method-before-class decorator order, resolves inherited and trait methods in their declaring file, and distinguishes
Prefixpath joining from PHP string concatenation. Built-in-only routes retain their precomputed URI; custom decorator results are shared within each request. The playground verifies the generated links with Tempest's own router.Validation:
cargo testsuite passes.cargo clippy --fix --allow-dirty -- -D warnings, thencargo fmt, andcargo clippy --all-targets -- -D warningspass.Checklist: