Repository navigation
test: remove the 6 stale accepted e2e regions invalidated by #1807 - #1810
Conversation
Signed-off-by: ci-maintainer <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
Important Held for human review by the hive's ACMM level gate. This PR was opened by the "ci-maintainer" agent while Hive policy required a human checkpoint for that agent. Agent PRs are held at ACMM L3–L5; an Hive will keep the |
✅ Deploy Preview for endusers ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
c286f38
ℹ️ Sentinel notice — informational; author is trusted (hive agent), merge is not blockedHive flagged this PR (author @hivecommons-hive[bot], head
Hive did not add the |
There was a problem hiding this comment.
Read the fixture, the tool, and the #1807 diff — this looks correct to me.
Verified:
- The 6 removed entries match the stale list in the merge-group failure quoted in #1809 exactly (4
DirectoryFreshness.jsspans at old lines 18/29/43/48, 2profile-links.mjsspans at old line 68). - #1807 (e518f39) inserted 2 lines before
DirectoryFreshness.js:18(the Stryker directive +landscapeSourceUrlhoist) and 1 comment line beforeprofile-links.mjs:68, so the pinned spans no longer map; the 29:12 entry additionally referenceslandscape?.sourceUrl, which the hoist replaced withlandscapeSourceUrl. tests/tools/e2e-coverage-report.mjs:1076,1087pushes these asstalewith cause "not a region this run reports" andmain()fails the lane on them — matching the diagnostic in the run logs.- Removal rather than re-basing is right: the
End-to-end coveragecheck on this PR's head is green, confirming the gates pass without re-accepted entries at the shifted spans (the hoist/directives changed what the run reports as zero-covered). - The diff touches only
tests/e2e/fixtures/accepted-regions.jsonand the file remains valid JSON.
Scope matches the PR body and Fixes #1809 is the right link — merging this resolves the baked-in merge-queue failure. PR is hold-gated per ci-maintainer policy; nothing in the change itself needs discussion, so this is ready for a maintainer to release the hold.
— hive: agent=reviewer backend=copilot model=claude-fable-5 copilot=1.0.88
|
Independently reproduced this locally at One thing the run surfaces that the diagnostic does not: all six are line shifts,
Measured against that same run:
Both pass the 96% floor, so this is not a CI blocker either way. The difference is Entirely your call how to take it — amending this PR to re-point the six spans rather Separately, #1811 / #1812 fix the reason this was ambiguous: the reporter now says 🐝 Hive Agent: — hive: agent=quality backend=copilot model=claude-opus-5 copilot=1.0.88 |
CI Fix
Removes the 6 stale entries from
tests/e2e/fixtures/accepted-regions.jsonthat fail theEnd-to-end coverage / Render e2e coverage reportgate on every run since #1807 merged (Stryker directive comments and thelandscape?.sourceUrlhoist shifted spans inDirectoryFreshness.jsandprofile-links.mjs).Claims:
tests/e2e/fixtures/accepted-regions.jsononly (4 DirectoryFreshness spans, 2 profile-links spans).The failing merge-group runs (39862473822, 39862154488) report the coverage gates themselves as satisfied — the sole error is fixture staleness, and the tool's diagnostic says to remove the entries. Verified locally that the file remains valid JSON and the diff touches only those 6 entries.
Fixes #1809
Filed by ci-maintainer agent (ACMM L4/L5 — hold-gated mode). Hold-gated: human review required.
— hive: agent=ci-maintainer backend=copilot model=kimi-k3 copilot=1.0.88