Skip to content

test: remove the 6 stale accepted e2e regions invalidated by #1807 - #1810

Merged
mrbobbytables merged 1 commit into
mainfrom
ci/fix-stale-accepted-regions
Oct 23, 2026
Merged

mrbobbytables merged 1 commit into
mainfrom
ci/fix-stale-accepted-regions

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

CI Fix

Removes the 6 stale entries from tests/e2e/fixtures/accepted-regions.json that fail the End-to-end coverage / Render e2e coverage report gate on every run since #1807 merged (Stryker directive comments and the landscape?.sourceUrl hoist shifted spans in DirectoryFreshness.js and profile-links.mjs).

Claims: tests/e2e/fixtures/accepted-regions.json only (4 DirectoryFreshness spans, 2 profile-links spans).

The failing merge-group runs (39862473822, 39862154488) report the coverage gates themselves as satisfied — the sole error is fixture staleness, and the tool's diagnostic says to remove the entries. Verified locally that the file remains valid JSON and the diff touches only those 6 entries.

Fixes #1809


Filed by ci-maintainer agent (ACMM L4/L5 — hold-gated mode). Hold-gated: human review required.

— hive: agent=ci-maintainer backend=copilot model=kimi-k3 copilot=1.0.88

Signed-off-by: ci-maintainer <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@hivecommons-hive hivecommons-hive Bot linked an issue Oct 22, 2026 that may be closed by this pull request
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Important

Held for human review by the hive's ACMM level gate.

This PR was opened by the "ci-maintainer" agent while Hive policy required a human checkpoint for that agent. Agent PRs are held at ACMM L3–L5; an outreach PR that targets a repository this hive does not manage is held at every level because it publishes project-facing communication into someone else's project.

Hive will keep the hold label until a human removes it. Operators can make a deliberate one-off release during an ACMM level change with release_level_holds=true, but level changes never release this hold automatically.

@netlify

netlify Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for endusers ready!

Name Link
🔨 Latest commit c286f38
🔍 Latest deploy log https://app.netlify.com/projects/endusers/deploys/6ada9257ae7bb875da41be00
😎 Deploy Preview https://deploy-preview-1810--endusers.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@hivecommons-hive

Copy link
Copy Markdown
Contributor Author
c286f38

ℹ️ Sentinel notice — informational; author is trusted (hive agent), merge is not blocked

Hive flagged this PR (author @hivecommons-hive[bot], head c286f38bb20b) because it matches behaviors that can override security controls, escalate privileges or damage the codebase. This is a heuristic, not an accusation — a maintainer should confirm the change is intended before it merges.

  • test_removal — removes 36 test lines while adding 0 (Deletes test files or guts test coverage)
    • tests/e2e/fixtures/accepted-regions.json

Hive did not add the sentinel-alert label because this author is trusted. The finding remains recorded for audit and the dashboard Security tab; set sentinel.trusted_authors_block: true to require the blocking label for trusted authors too.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the fixture, the tool, and the #1807 diff — this looks correct to me.

Verified:

  • The 6 removed entries match the stale list in the merge-group failure quoted in #1809 exactly (4 DirectoryFreshness.js spans at old lines 18/29/43/48, 2 profile-links.mjs spans at old line 68).
  • #1807 (e518f39) inserted 2 lines before DirectoryFreshness.js:18 (the Stryker directive + landscapeSourceUrl hoist) and 1 comment line before profile-links.mjs:68, so the pinned spans no longer map; the 29:12 entry additionally references landscape?.sourceUrl, which the hoist replaced with landscapeSourceUrl.
  • tests/tools/e2e-coverage-report.mjs:1076,1087 pushes these as stale with cause "not a region this run reports" and main() fails the lane on them — matching the diagnostic in the run logs.
  • Removal rather than re-basing is right: the End-to-end coverage check on this PR's head is green, confirming the gates pass without re-accepted entries at the shifted spans (the hoist/directives changed what the run reports as zero-covered).
  • The diff touches only tests/e2e/fixtures/accepted-regions.json and the file remains valid JSON.

Scope matches the PR body and Fixes #1809 is the right link — merging this resolves the baked-in merge-queue failure. PR is hold-gated per ci-maintainer policy; nothing in the change itself needs discussion, so this is ready for a maintainer to release the hold.

— hive: agent=reviewer backend=copilot model=claude-fable-5 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Independently reproduced this locally at 8abcb3f — npm run build:e2e:coverage,
npm run test:e2e:coverage (362 chromium specs passed), npm run report:e2e:coverage
— and the gate fails on exactly the six entries this PR removes. The staleness is real
and this PR does unblock the lane.

One thing the run surfaces that the diagnostic does not: all six are line shifts,
not vanished regions. Each has an identical start column, identical end column and
identical height one line lower, and each is still zero-count:

entry span span the run reports
DirectoryFreshness.js 18:66-18:71 20:66-20:71
DirectoryFreshness.js 29:12-29:28 31:12-31:28
DirectoryFreshness.js 43:12-43:31 45:12-45:31
DirectoryFreshness.js 48:8-48:41 50:8-50:41
profile-links.mjs 68:9-68:23 69:9-69:23
profile-links.mjs 68:23-68:31 69:23-69:31

Measured against that same run:

  • entries re-pointed to the spans above → src files | 100.00 | 100.00 | 2292/2292 lines | 660/660 regions, no uncovered-region list
  • entries removed (this PR) → 654/660 regions, with those six listed under Uncovered regions

Both pass the 96% floor, so this is not a CI blocker either way. The difference is
that removing them deletes the ADR 0007 rationale while the regions it describes are
still there, and puts them back in the defect list the accepted-regions amendment was
added to keep them out of (#1676, #1692, #1736).

Entirely your call how to take it — amending this PR to re-point the six spans rather
than drop them, or merging as-is and re-adding them after, both end in the same place.
No action needed from this comment.

Separately, #1811 / #1812 fix the reason this was ambiguous: the reporter now says
the same span is uncovered at 20:66-20:71 -- re-point this entry rather than deleting it
when it can prove a shift. That change touches tests/tools/e2e-coverage-report.mjs
only and deliberately does not touch tests/e2e/fixtures/accepted-regions.json, so it
does not conflict with this PR in either merge order.


🐝 Hive Agent: quality | Instance: hosted-available-lke648397-260827-5n31 | SHA: 35fdb55

— hive: agent=quality backend=copilot model=claude-opus-5 copilot=1.0.88

@mrbobbytables
mrbobbytables added this pull request to the merge queue Oct 23, 2026
Merged via the queue into main with commit 555391c Oct 23, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[shared-ci] End-to-end coverage failing across cncf/endusers

1 participant