Remove eight deprecated no-op CLI flags - #7790
Open
CharlieTLe wants to merge 1 commit into
Open
Conversation
dosubot
Bot
added
go
This was referenced Aug 20, 2026
All eight have been past the two-minor deprecation window in v1-guarantees.md for at least three minors, and every one is flag-only with no YAML config option and no effect on behaviour, so removing them cannot change how a running cluster behaves. The only impact is that a command line still passing one now fails at startup. Split out from the deprecation removals that do touch YAML config or behaviour, so an objection to those does not hold these up. docs/blocks-storage/migrate-from-chunks-to-blocks.md stops telling readers to set -querier.ingester-streaming. That guide still references other flags removed years ago (-querier.second-store-engine, -querier.use-second-store-before-time); worth a separate look at whether it should stay at all. Signed-off-by: Charlie Le <charlie_le@apple.com>
CharlieTLe
force-pushed
the
release-1.22-pr-d1-remove-noop-flags
branch
from
August 20, 2026 01:18
d1c825f to
f551242
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Groundwork for v1.22.0. Refs #5922. First of three deprecation-removal PRs, split so that
an objection to the riskier ones does not hold up eight trivially-correct deletions.
Every flag here is flag-only (no YAML config option) and already a no-op, so
removing it cannot change how a running cluster behaves. The only impact is that a command
line still passing one now fails at startup.
-querier.ingester-streaming-querier.iterators-querier.batch-iterators-querier.query-store-for-labels-enabled-querier.max-outstanding-requests-per-tenant-query-scheduler.max-outstanding-requests-per-tenant-blocks-storage.tsdb.wal-compression-enabled-ingester.max-series-per-queryv1-guarantees.mdpromises deprecated flags stay for two minor releases; all of these areat least three past that.
No generated-doc churn
flagext.DeprecatedFlagregisters a CLI flag with no backing struct field, so none of theseappear in
docs/configuration/config-file-reference.mdor the JSON schema. Confirmed:make docproduces an empty diff on this branch.Docs
docs/blocks-storage/migrate-from-chunks-to-blocks.mdwas the only doc telling readers toset
-querier.ingester-streaming, so those mentions are gone.Worth noting separately: that guide is already broadly stale — it still documents
-querier.second-store-engine,-querier.use-second-store-before-timeand-querier.query-store-after, all of which were removed some time ago. I only touched theone flag this PR removes; whether the guide should still exist is a separate call.
Verification
go build ./...,go vet,make doc(no diff), and the tests for every touched package.