Repository navigation
fix(integrations): validate servicenow, salesforce, and hubspot against vendor docs - #10027
Merged
waleedlatif1 merged 5 commits intoNov 14, 2026
Merged
Conversation
…s, query, limit, fields, and display value on tool calls
…ted instance and encode path ids
…s leaking into search
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 60 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
Contributor
[Medium impact] The PR appears safe to merge. SummaryThe PR fixes request paths and tool-call arguments across three integrations.
The latest changes add compatible TypeScript annotations. No new actionable issues or rule violations were found. Reviews (2) · Last reviewed commit: "fix(servicenow): type the mapper context..." · Reviewed by Greptile |
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validated ServiceNow, Salesforce, and HubSpot against each vendor's docs. Endpoints, methods, params, and pagination were already correct; the fixes are in the request path and the agent tool-call path.
state,comments,closeCode,closeNotes, Search Knowledgequery, List Attachmentslimit,displayValue, and field projection with blank dedicated subBlocks (Resolve Incident sent no close code/notes). Blank dedicated fields now fall back to the model's argument; a stored Create/Update JSON body is never sent as a projection. Canvas runs send exactly what they did beforequery_moreresolved an absolutenextRecordsUrlintohttps://org/https://org/...; it now reduces a same-origin URL to its path and rejects other hosts or paths outside/services/data/. Record, report, and dashboard ids are trimmed and path-encoded (report/dashboard ids were checked trimmed but sent untrimmed)safeUrlPathSegment(emails used withidProperty=emailcontaining#/?broke the URL). A get-operationpropertiesvalue (comma-separated) no longer leaks into the search tools, whichJSON.parseit and threwType of Change
Testing
utils.test.tscases (fail on old code)blockstests,check-block-registry,check:tool-metadata,check:docs,check:docs-manifest, biomeChecklist
test-auditauthoring gate)