Skip to content

fix(integrations): validate servicenow, salesforce, and hubspot against vendor docs - #10027

Merged
waleedlatif1 merged 5 commits into
stagingfrom
fix/validate-servicenow-salesforce-hubspot
Nov 14, 2026
Merged

waleedlatif1 merged 5 commits into
stagingfrom
fix/validate-servicenow-salesforce-hubspot

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

Validated ServiceNow, Salesforce, and HubSpot against each vendor's docs. Endpoints, methods, params, and pagination were already correct; the fixes are in the request path and the agent tool-call path.

  • ServiceNow: on agent tool calls, the block mapper overwrote the model's state, comments, closeCode, closeNotes, Search Knowledge query, List Attachments limit, displayValue, and field projection with blank dedicated subBlocks (Resolve Incident sent no close code/notes). Blank dedicated fields now fall back to the model's argument; a stored Create/Update JSON body is never sent as a projection. Canvas runs send exactly what they did before
  • Salesforce: query_more resolved an absolute nextRecordsUrl into https://org/https://org/...; it now reduces a same-origin URL to its path and rejects other hosts or paths outside /services/data/. Record, report, and dashboard ids are trimmed and path-encoded (report/dashboard ids were checked trimmed but sent untrimmed)
  • HubSpot: every path id goes through safeUrlPathSegment (emails used with idProperty=email containing #/? broke the URL). A get-operation properties value (comma-separated) no longer leaks into the search tools, which JSON.parse it and threw

Type of Change

  • Bug fix

Testing

  • New ServiceNow block tests for the tool-call path (each fails on the old mapper), Salesforce utils.test.ts cases (fail on old code)
  • Affected integration suites (182 tests), blocks tests, check-block-registry, check:tool-metadata, check:docs, check:docs-manifest, biome
  • Independent audit of every hunk against vendor docs and saved-workflow compatibility

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 14, 2026 1:52am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 60 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/sim/blocks/blocks/servicenow.ts Resolved
@greptile-apps

greptile-apps Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge.

Summary

The PR fixes request paths and tool-call arguments across three integrations.

  • ServiceNow tool calls keep model values when dedicated fields are blank.
  • Salesforce tools keep pagination and resource IDs within the connected org's paths.
  • HubSpot tools keep IDs inside one URL segment and pass search its own properties.

The latest changes add compatible TypeScript annotations. No new actionable issues or rule violations were found.

Reviews (2) · Last reviewed commit: "fix(servicenow): type the mapper context..." · Reviewed by Greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 14, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 60 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit b830c2e into staging Nov 14, 2026
80 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/validate-servicenow-salesforce-hubspot branch November 14, 2026 02:47

This branch was previously deployed

1 inactive deployment
Preview — 9444e2af Deployed Nov 14, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant