Skip to content

fix(mailchimp): archive members correctly, add permanent delete, and align requests with the marketing api - #10031

Merged
waleedlatif1 merged 5 commits into
stagingfrom
fix/validate-mailchimp
Nov 14, 2026
Merged

waleedlatif1 merged 5 commits into
stagingfrom
fix/validate-mailchimp

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

Validated Mailchimp against the official Marketing API spec.

  • Archive Member did nothing: it sent DELETE .../actions/delete-permanent, which only accepts POST. It now archives with DELETE /lists/{id}/members/{hash}, the documented archive
  • New Permanently Delete Member operation: POST .../actions/delete-permanent, the documented erasure, kept out of the first dropdown slot
  • Member addressing: emails are sent as the documented subscriber_hash (MD5 of the lowercase email), which addresses the same member. Every path id goes through safeUrlPathSegment
  • Unarchive: now sends the required status_if_new
  • Member tags: tags get the required status, and comma-separated names are accepted. Input with no tag names now errors instead of sending a silent no-op
  • Batch: operation bodies are sent as the JSON strings the spec requires. Unparseable operations now error instead of sending an empty batch
  • Docs: the member removal note is updated

Type of Change

  • Bug fix

Testing

  • New mailchimp.test.ts (regression cases fail on the pre-fix tools)
  • blocks tests, check-block-registry, check:tool-metadata, check:docs, check:docs-manifest, biome
  • Independent audit against the spec and saved-workflow compatibility

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Nov 14, 2026 2:17am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Critical impact] The PR appears safe to merge; no blocking issues were found.

Summary

The PR fixes Mailchimp member archiving, adds a separate permanent-delete action, and updates member paths, tags, batch requests, and docs.

  • Mailchimp offers separate archive and permanent-delete actions.
  • Mailchimp member requests use the correct hash and safe path IDs.
  • Mailchimp tag, batch, and restore requests use the expected fields.

Reviews (3) · Last reviewed commit: "fix(mailchimp): reject tag statuses othe..." · Reviewed by Greptile

Comment thread apps/sim/tools/mailchimp/types.ts Resolved

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 74 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/sim/tools/mailchimp/types.ts Resolved
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 14, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 74 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/sim/tools/mailchimp/types.ts Resolved
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 14, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 74 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

This branch was successfully deployed

1 active deployment
Preview — b500a0e6 Deployed Nov 14, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant