Repository navigation
fix(mailchimp): archive members correctly, add permanent delete, and align requests with the marketing api - #10031
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
[Critical impact] The PR appears safe to merge; no blocking issues were found. SummaryThe PR fixes Mailchimp member archiving, adds a separate permanent-delete action, and updates member paths, tags, batch requests, and docs.
Reviews (3) · Last reviewed commit: "fix(mailchimp): reject tag statuses othe..." · Reviewed by Greptile |
There was a problem hiding this comment.
All reported issues were addressed across 74 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 74 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
… member emails and guard path ids, require status_if_new on unarchive, default tag status, stringify batch bodies
…no-ops, keep numeric tag names, document the archive and permanent delete actions
…reject malformed JSON
1f523ad to
b500a0e
Compare
Summary
Validated Mailchimp against the official Marketing API spec.
DELETE .../actions/delete-permanent, which only acceptsPOST. It now archives withDELETE /lists/{id}/members/{hash}, the documented archivePOST .../actions/delete-permanent, the documented erasure, kept out of the first dropdown slotsubscriber_hash(MD5 of the lowercase email), which addresses the same member. Every path id goes throughsafeUrlPathSegmentstatus_if_newstatus, and comma-separated names are accepted. Input with no tag names now errors instead of sending a silent no-opType of Change
Testing
mailchimp.test.ts(regression cases fail on the pre-fix tools)blockstests,check-block-registry,check:tool-metadata,check:docs,check:docs-manifest, biomeChecklist
test-auditauthoring gate)