Repository navigation
Wait for the saved repository choice in the dashboard switch test - #121
Merged
Merged
Conversation
Since J8 a page switch shows the new selection first and saves right after, so the test sometimes read beta-shell.json before the save and failed on main (run 42763028808, 4f8da19). It now waits up to 5 s for the saved value, like the target-path test does, and treats a file caught mid-write as not yet saved. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The UI test
Dashboard_SwitchingToARepositoryWithoutFoldersKeepsRunningfailed once onmainafter #118 merged (run 42763028808,4f8da19): it expectedSelectedRepositoryIdto beempty-repositorybut readui-repository.Since J8 (#117), a page switch shows the new selection first and saves the settings right after. The test read
beta-shell.jsonimmediately after the click, so it sometimes got the file before the save. The app's behaviour is fine; the same test passed on #118, #119 and #120.The test now waits up to 5 s for the saved value, like the target-path test next to it does. A file caught mid-write or locked counts as not yet saved. Only the test changes.
Test plan
mainplus Settings: even out the two columns on wide windows #119🤖 Generated with Claude Code