Stop OON reply filter from dropping followee Phoenix replies - #183
Closed
Pitchfork-and-Torch wants to merge 1 commit into
Closed
Conversation
This was referenced Sep 8, 2026
Phoenix, MOE, Topics, and TweetMixer set in_reply_to_tweet_id and leave ancestors empty. OONRetweetReplyFilter treated empty ancestors as a hard drop, so in-network followee replies never reached scoring or VF. Thunder already copies the parent into ancestors and survived. OON retweets and replies still drop.
Pitchfork-and-Torch
force-pushed
the
cursor/magellan-freespeech-oon-reply-ancestors-e29b
branch
from
September 8, 2026 23:07
0ae9eb6 to
902a06f
Compare
Author
|
Parking this intern-stack PR per operator GitHub cleanup (2026-09-08). Hunt notes remain local. Not a reject of the class. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Phoenix, MOE, Topics, and TweetMixer set
in_reply_to_tweet_idand leaveancestorsempty. Thunder copies the parent intoancestors.OONRetweetReplyFilterdropped any reply with emptyancestors, includingin_network == Some(true). That ran in the pre-score filter chain, before Phoenix scoring and before VF.A followee reply retrieved by Phoenix never reached For You. The same reply from Thunder survived.
This is not #179 (seen/served treating a reply as its parent). Not #180 (VF skipping Phoenix reply parents). #180 is post-selection ancillary VF. These cards died before that hydrator. Not #99 (self-reply chains). OON retweets and OON replies still drop.
Five-line proof
in_reply_to_tweet_idand leaveancestorsemptyOONRetweetReplyFilteronPhoenixCandidatePipeline(pre-score)(is_reply && ancestors.is_empty())fired afterInNetworkCandidateHydratorstamped a followee replyin_network = truein_reply_tointoancestorsand is kept; OON replies still dropFix
Drop only OON retweets and OON replies. Empty ancestors is a producer gap, not an OON signal.
Tests
cargo testcannot run. Public dump has no Home Mixer manifest. Standalone rustc model of the keep/drop predicate passed.Fork PR: none (closed Pitchfork-and-Torch#65 as wrong tree)