Repository navigation
Settings: even out the two columns on wide windows - #119
Merged
Merged
Conversation
Maximized, the main column ended about 300 DIP above the side column, which left the lower part of the main column empty. The side column's later groups (online category, diagnostics, project) are now units; with two columns the page moves the set that best evens out the column bottoms to the end of the main column, in their own order (SettingsLayoutPolicy.BalanceColumns, unit tested). It decides from the content heights after layout, again when the width or the language changes. Column bottoms, main vs side (DIP): - maximized (2560x1392): before 295-358 apart (side longer); after the project group moves: zh 29, en 59, ru 91 apart. - 1400x900: after: en 172, zh 140 (project moves), ru 115 (online moves). Below the 1180 DIP breakpoint every group is back in the side panel in its original order. Tab order follows the panels (main column, then side column), matching what is seen; automation names are unchanged. A UI test checks both. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2 tasks done
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #104. Maximized, the Settings page's main column ended far above the information rail, leaving a large empty area in the lower left (295–358 DIP difference between the column bottoms).
SettingsLayoutPolicy) with unit tests.Difference between the two column bottoms:
Which group moves depends on the window height, so on a much smaller screen a different group may move than on the machine these were measured on.
Test plan
scripts\test-all.ps1: 1,758 Core tests, Release build 0 warnings, Core coverage 94.0% line / 88.4% branch; 5 newSettingsLayoutPolicytestsmain(with Stage J8: DialogService, dialogs in Dialogs/, and a dialog redesign #117 and Stage J6: move the Online page out of the window, with a new drawer, toolbar and states #118) in a local preview:test-allpasses, 0 warnings🤖 Generated with Claude Code