Repository navigation
Stage J7: move the Mod workspace interface out of the window - #120
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The rules (reading bindings from a Mod's files, the automatic binding and its description, upgrading old automatic bindings, link normalising) are shared with the online install and stay with the window; the row editor moves with the Mod workspace page next. Pure move inside MainWindow. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The workspace XAML (with the styles only it uses and the combination preset holder CombinationProfileControlsHost) moves to Pages/WorkspacePage.xaml, and its interface files to Pages/Workspace/WorkspacePage.*.cs: RepositoryWorkspace, RefinedWorkspace, LocalLibrary, LocalTags, BatchModActions, CharacterSelection, ExistingModImport, CharacterAvatars and the ShortcutBindings editor. The logic stays with the window (decided 2026-11-10): state slots, variants, default slots, preset previews, combination presets and bundles, preset share, archives, copy ownership (#107), character rename migration (#108), INI conflicts and the shortcut binding rules. The page reaches the window only through IWorkspaceHost (77 members in 18 commented groups) and never references the MainWindow type; the 12 page controls whose handlers are that logic are subscribed by the window. CharacterFollowProfile becomes a top-level type; WrapperPage, now unused, is removed. No behaviour change. The 54 workspace screenshots (zh/en/ru, 1400x900, 1000x800 and 670x530, light/dark, the preview, shortcut, slot and preset views) match the baseline apart from the temporary test folder path in the status bar and the window edge; test-all, all UI tests and the style check pass. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2 tasks done
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stage J7: the Mod workspace interface moves out of
MainWindow(docs/development/UI-Structure-Plan.md, J7). The inventory found 20 files and 6,455 lines; about half of the ~90 outside references come from the Shortcuts page and overlay and use state slot, preset preview and combination preset code whose results must not change. So this PR moves the interface only (option 1, chosen by the maintainer). The appearance work (J7-b) comes in its own PR after this one.e3a83c3: the inventory, inUI-Structure-Plan.md("J7 牵连清单").f3c7986: the shortcut binding rules are split from the binding editor. This is a pure move inside the window; the online install uses the rules too.7244916: pure move intoPages/WorkspacePage.xamlandPages/Workspace/.CombinationProfileControlsHost;RepositoryWorkspace,RefinedWorkspace,LocalLibrary,LocalTags,BatchModActions,CharacterSelection,ExistingModImport,CharacterAvatars;ShortcutBindings.IWorkspaceHost: 77 members in 18 commented groups, all used. The page never referencesMainWindow.CharacterFollowProfilebecame a top-level type, and the unusedWrapperPagewas removed.fb013fa: a follow-up inUI-Structure-Plan.md("J7 后续") to splitIWorkspaceHostinto slot, preset preview, combination preset and install services plus shared workspace state, with the member count.MainWindow: code 14,428 → 10,417 lines;MainWindow.xaml705 → 145 lines. The page is 4,908 lines.Timings, as the baseline for J7-b (median of 6, two runs each; part of each figure is the UI-automation check, about 45 ms for a character and 14 ms for a Mod):
Test plan
scripts\test-all.ps1: 1,779 Core tests, Release build 0 warnings, Core coverage 94.0% line / 88.2% branchmod.ini.🤖 Generated with Claude Code