Repository navigation
Temporarily remove Scotland population live test - #3875
Merged
Merged
Conversation
This was referenced Oct 8, 2026
Draft
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3875 +/- ##
===========================================
+ Coverage 45.22% 87.56% +42.33%
===========================================
Files 183 198 +15
Lines 11073 12211 +1138
Branches 1905 2159 +254
===========================================
+ Hits 5008 10692 +5684
+ Misses 5644 922 -4722
- Partials 421 597 +176 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
anth-volk
marked this pull request as ready for review
October 9, 2026 00:21
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3874
Temporarily remove the Scotland population live test that fails because the simulation worker filters UK household inputs by a nonexistent
countrycolumn. This intentionally leaves that failing population behavior uncovered until the upstream repair is released and deployed. The Scotland household calculation test, Utah and California population tests, and Scotland fixtures remain.Remove the deleted live function's local request-contract parametrization as well, so unit test collection continues to work. The follow-up API PR will restore both the live test and this parametrization.
Upstream fix: PolicyEngine/policyengine.py#565 (issue PolicyEngine/policyengine.py#564). Release order: merge this temporary removal; publish the corrected
.pypackage (expected 6.2.3); upgrade and deploy the simulation API in PolicyEngine/policyengine-sim-api#733 (issue PolicyEngine/policyengine-sim-api#732); then upgrade API v1 and restore the Scotland population test in #3877 (issue #3876). This PR does not repair the simulation behavior.Validation: 3 focused live-request unit tests passed; the deployed live suite collects 9 tests, including the Scotland household test. Repository formatting, changed-file Ruff checks, changelog validation, and
git diff --checkpassed. The deployed suite was not executed locally; collecting it does not validate a deployment.