Repository navigation
Conversation
This was referenced Oct 8, 2026
Draft
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3876
Restore the Scotland population live test and its local request-contract parametrization removed by #3875, and require
policyengine[models]==6.2.3in the API project and generic Dockerfile. Both restored test files match their pre-removal versions exactly; the Scotland request must returnstatus == "ok"and a finite budgetary impact.Stacked PR: the base is
fix/temporarily-remove-scotland-live-test(#3875) so this diff visibly restores the test. Merge #3875 first, then retarget/rebase this PR ontomaster, preserving the restored tests if the removal was squash-merged. PR checks run for this branch arrangement.Upstream fix: PolicyEngine/policyengine.py#565 (issue PolicyEngine/policyengine.py#564). Simulation-worker upgrade: PolicyEngine/policyengine-sim-api#733 (issue PolicyEngine/policyengine-sim-api#732). The worker must select Scotland, Wales, and Northern Ireland through the stored household
regioncolumn; upgrading API v1 alone cannot change an already deployed worker.Expected CI failure: 6.2.3 is not published yet. Add
uv lock --checkbefore the existing simulation-API support check so the PR fails immediately withthere is no version of policyengine[models]==6.2.3, before it attempts to validate a worker or use the stale frozen environment. Keep this check after release so future bundle changes must have a current lockfile.The genuine existing lockfile is deliberately unchanged until the release exists. Before merge: confirm the published version contains the upstream fix; run and commit
uv lock --upgrade-package policyengine; finish the simulation-API upgrade, deployment, and qualification; then pass API dependency, worker-version, build, and test checks. If another release consumes 6.2.3 first, update both downstream PRs to the actual fixed version. Do not replace the package with a Git checkout, weaken assertions, or skip the restored test.Validation now: 124 focused live-request, bundle-update, and deployment-script unit tests passed using the existing installed 6.2.1 dependencies, which does not validate 6.2.3. The live suite collects 10 tests including both Scotland population and household tests. Repository formatting, changed-file Ruff checks, changelog validation, and whitespace checks passed.
uv lock --checkreproduces the expected missing-release failure. The restored population test still requires a successful run against the deployed staging candidate before API promotion.